Expose JSON stringifier through V8 API

Expose JSON stringifier through V8 API

BUG=587995
LOG=N

[please use gerrit instead, 2016-03-31 23:11:38]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-03-31 23:17:11]

rouslan@chromium.org changed reviewers:
+ jochen@chromium.org, verwaest@chromium.org

[please use gerrit instead, 2016-03-31 23:17:12]

jochen@ & verwaest@: Not ready for a review yet, but this issue has stomped me:

ld.gold: error:
obj/tools/gyp/libv8_base.a(obj/tools/gyp/../../src/runtime/v8_base.runtime-json.o):
multiple definition of 'bool
v8::internal::BasicJsonStringifier::DoNotEscape<unsigned char>(unsigned char)'
ld.gold: obj/tools/gyp/libv8_base.a(obj/tools/gyp/../../src/v8_base.api.o):
previous definition here

Am I missing something obvious here? All #ifdef and gyp files seem to be in
order.

https://codereview.chromium.org/1847823004/diff/20001/src/api.cc
File src/api.cc (left):

https://codereview.chromium.org/1847823004/diff/20001/src/api.cc#oldcode69
src/api.cc:69: 
Result of `git cl format`.

https://codereview.chromium.org/1847823004/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1847823004/diff/20001/src/api.cc#newcode55
src/api.cc:55: #include "src/property.h"
Result of `git cl format`.

https://codereview.chromium.org/1847823004/diff/20001/src/api.cc#newcode57
src/api.cc:57: #include "src/runtime-profiler.h"
Result of `git cl format`.

[jochen (gone - plz use gerrit), 2016-04-01 08:42:09]

I guess you need to extract the code from runtime-json.cc into a helper method
on the Runtime class (similar to Runtime::SetObjectProperty)

[please use gerrit instead, 2016-04-01 22:28:38]

Description was changed from

==========
Expose JSON stringifier through V8 API

BUG=587995
==========

to

==========
Expose JSON stringifier through V8 API

BUG=587995
LOG=N
==========

[please use gerrit instead, 2016-04-01 23:22:26]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 23:22:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847823004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847823004/40001

[commit-bot: I haz the power, 2016-04-01 23:55:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 23:55:20]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-04-04 10:43:38]

verwaest@chromium.org changed reviewers:
+ yangguo@chromium.org

[Toon Verwaest, 2016-04-04 10:43:39]

+yangguo who owns the json stringifier

https://codereview.chromium.org/1847823004/diff/40001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1847823004/diff/40001/include/v8.h#newcode1668
include/v8.h:1668: * A JSON Parser.
This isn't just a parser anymore now.

https://codereview.chromium.org/1847823004/diff/40001/include/v8.h#newcode1692
include/v8.h:1692: Isolate* isolate, Local<Object> json_object);
Shouldn't this get the context as input, like v8::Object::Get? Probably the same
for Parse above.

[Yang, 2016-04-04 10:55:43]

https://codereview.chromium.org/1847823004/diff/40001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1847823004/diff/40001/include/v8.h#newcode1692
include/v8.h:1692: Isolate* isolate, Local<Object> json_object);
On 2016/04/04 10:43:39, Toon Verwaest wrote:
> Shouldn't this get the context as input, like v8::Object::Get? Probably the
same
> for Parse above.

The parser should definitely get a context as argument since the object it
creates is context-specific.

Not so sure about the stringifier though, as the returned string is
context-independent. But we probably do want access checks during stringifying
to check for the correct context?

[please use gerrit instead, 2016-04-06 18:39:00]

FYI, I plan to pick this back up mid-May.

[please use gerrit instead, 2016-04-15 17:21:13]

Will be finished in https://codereview.chromium.org/1891203002/.

[please use gerrit instead, 2016-04-15 17:21:19]

Description was changed from

==========
Expose JSON stringifier through V8 API

BUG=587995
LOG=N
==========

to

==========
Expose JSON stringifier through V8 API

BUG=587995
LOG=N
==========