Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: Source/modules/vibration/NavigatorVibration.cpp

Issue 18478003: Vibration cannot be canceled during pattern vibration. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Vibration cannot be canceled during pattern vibration. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/vibration/NavigatorVibration.cpp
diff --git a/Source/modules/vibration/NavigatorVibration.cpp b/Source/modules/vibration/NavigatorVibration.cpp
index bba89fcadf195bece96040d44363d7013086ccc3..ee9ae29ce65340d14fb1fca6094f5e14ddc74b51 100644
--- a/Source/modules/vibration/NavigatorVibration.cpp
+++ b/Source/modules/vibration/NavigatorVibration.cpp
@@ -85,6 +85,7 @@ bool NavigatorVibration::vibrate(const VibrationPattern& pattern)
}
m_timerStart.startOneShot(0);
+ m_isVibrating = true;
tkent 2013/08/28 03:58:07 It seems m_isVibrating is equivalent to m_timerSta
kihong 2013/08/28 05:25:25 It's not exactly same because if there are some co
return true;
}
@@ -114,7 +115,8 @@ void NavigatorVibration::timerStopFired(Timer<NavigatorVibration>* timer)
{
ASSERT_UNUSED(timer, timer == &m_timerStop);
- m_isVibrating = false;
+ if (m_pattern.isEmpty())
+ m_isVibrating = false;
if (m_pattern.size()) {
m_timerStart.startOneShot(m_pattern[0] / 1000.0);

Powered by Google App Engine
This is Rietveld 408576698