Vibration cannot be canceled during pattern vibration.

Source/modules/vibration/NavigatorVibration.cpp

 /*
  *  Copyright (C) 2012 Samsung Electronics
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Library General Public
  *  License as published by the Free Software Foundation; either
  *  version 2 of the License, or (at your option) any later version.
  *
  *  This library is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 67 matching lines @@
 
     if (!m_pattern.size())
         return true;
 
     if (m_pattern.size() == 1 && !m_pattern[0]) {
         m_pattern.clear();
         return true;
     }
 
     m_timerStart.startOneShot(0);
+    m_isVibrating = true;

[tkent, 2013/08/28 03:58:07]

It seems m_isVibrating is equivalent to m_timerStart.isActive() ||
m_timerStop.isActive() (if we apply the following comment).  We can remove
m_isVibrating.

[kihong, 2013/08/28 05:25:25]

It's not exactly same because if there are some codes like below, vibration can
not be canceled becuase of timer issue.
m_timerStart.startOneShort(0); is called by line:1 but timer could not be
activated until line:2 is called. Therefore cancel would be not worked.
Then device would be vibrating when timer is activated.
Therefore IMHO timer is not enough to check vibrating or not.

below ---------------------------
1: navigator.vibrate(1000);
2: navigator.vibrate(0);

     return true;
 }
 
 void NavigatorVibration::cancelVibration()
 {
     m_pattern.clear();
     if (m_isVibrating) {
         WebKit::Platform::current()->cancelVibration();
         m_isVibrating = false;
         m_timerStop.stop();

[tkent, 2013/08/28 03:58:07]

We had better stop m_timerStart too though timerStartFired will do nothing
because of m_pattern.clear().

     }
 }
 
 void NavigatorVibration::timerStartFired(Timer<NavigatorVibration>* timer)
 {
     ASSERT_UNUSED(timer, timer == &m_timerStart);
 
     if (m_pattern.size()) {
         m_isVibrating = true;
         WebKit::Platform::current()->vibrate(m_pattern[0]);
         m_timerStop.startOneShot(m_pattern[0] / 1000.0);
         m_pattern.remove(0);
     }
 }
 
 void NavigatorVibration::timerStopFired(Timer<NavigatorVibration>* timer)
 {
     ASSERT_UNUSED(timer, timer == &m_timerStop);
 
-    m_isVibrating = false;
+    if (m_pattern.isEmpty())
+        m_isVibrating = false;
 
     if (m_pattern.size()) {
         m_timerStart.startOneShot(m_pattern[0] / 1000.0);
         m_pattern.remove(0);
     }
 }
 
 void NavigatorVibration::pageVisibilityChanged()
 {
     if (page()->visibilityState() != PageVisibilityStateVisible)
@@ skipping 35 matching lines @@
     }
     return navigatorVibration;
 }
 
 const char* NavigatorVibration::supplementName()
 {
     return "NavigatorVibration";
 }
 
 } // namespace WebCore