Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Unified Diff: build/common.gypi

Issue 18477006: Do not turn on --fatal-warnings for android_webview_build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index c57f6c2d97842081d8d9bd966e82f95639013053..a61e7c703f9d0f403c363c25a6d4ab2c76088e71 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2771,6 +2771,12 @@
'-Wl,--warn-shared-textrel',
],
}],
+ ['OS=="android" and android_webview_build==1', {
+ 'ldflags!': [
+ # Must not turn on --fatal-warnings, see crbug.com/157326.
+ '-Wl,--fatal-warnings',
+ ],
+ }],
['OS=="android" and android_full_debug==0', {
# Some configurations are copied from Release_Base to reduce
# the binary size.
@@ -2844,6 +2850,12 @@
'-Wl,--warn-shared-textrel',
],
}],
+ ['OS=="android" and android_webview_build==1', {
+ 'ldflags!': [
+ # Must not turn on --fatal-warnings, see crbug.com/157326.
+ '-Wl,--fatal-warnings',
+ ],
+ }],
['clang==1', {
'cflags!': [
'-fno-ident',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698