Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: build/common.gypi

Issue 18477006: Do not turn on --fatal-warnings for android_webview_build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2753 matching lines...) Expand 10 before | Expand all | Expand 10 after
2764 'ldflags': [ 2764 'ldflags': [
2765 '-Wl,--fatal-warnings', 2765 '-Wl,--fatal-warnings',
2766 # Only link with needed input sections. This is to avoid 2766 # Only link with needed input sections. This is to avoid
2767 # getting undefined reference to __cxa_bad_typeid in the CDU 2767 # getting undefined reference to __cxa_bad_typeid in the CDU
2768 # library. 2768 # library.
2769 '-Wl,--gc-sections', 2769 '-Wl,--gc-sections',
2770 # Warn in case of text relocations. 2770 # Warn in case of text relocations.
2771 '-Wl,--warn-shared-textrel', 2771 '-Wl,--warn-shared-textrel',
2772 ], 2772 ],
2773 }], 2773 }],
2774 ['OS=="android" and android_webview_build==1', {
2775 'ldflags!': [
2776 # Must not turn on --fatal-warnings, see crbug.com/157326.
2777 '-Wl,--fatal-warnings',
2778 ],
2779 }],
2774 ['OS=="android" and android_full_debug==0', { 2780 ['OS=="android" and android_full_debug==0', {
2775 # Some configurations are copied from Release_Base to reduce 2781 # Some configurations are copied from Release_Base to reduce
2776 # the binary size. 2782 # the binary size.
2777 'variables': { 2783 'variables': {
2778 'debug_optimize%': 's', 2784 'debug_optimize%': 's',
2779 }, 2785 },
2780 'cflags': [ 2786 'cflags': [
2781 '-fomit-frame-pointer', 2787 '-fomit-frame-pointer',
2782 '-fdata-sections', 2788 '-fdata-sections',
2783 '-ffunction-sections', 2789 '-ffunction-sections',
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
2837 }, 2843 },
2838 'cflags': [ 2844 'cflags': [
2839 '-fomit-frame-pointer', 2845 '-fomit-frame-pointer',
2840 ], 2846 ],
2841 'ldflags': [ 2847 'ldflags': [
2842 '-Wl,--fatal-warnings', 2848 '-Wl,--fatal-warnings',
2843 # Warn in case of text relocations. 2849 # Warn in case of text relocations.
2844 '-Wl,--warn-shared-textrel', 2850 '-Wl,--warn-shared-textrel',
2845 ], 2851 ],
2846 }], 2852 }],
2853 ['OS=="android" and android_webview_build==1', {
2854 'ldflags!': [
2855 # Must not turn on --fatal-warnings, see crbug.com/157326.
2856 '-Wl,--fatal-warnings',
2857 ],
2858 }],
2847 ['clang==1', { 2859 ['clang==1', {
2848 'cflags!': [ 2860 'cflags!': [
2849 '-fno-ident', 2861 '-fno-ident',
2850 ], 2862 ],
2851 }], 2863 }],
2852 ['profiling==1', { 2864 ['profiling==1', {
2853 'cflags': [ 2865 'cflags': [
2854 '-fno-omit-frame-pointer', 2866 '-fno-omit-frame-pointer',
2855 '-g', 2867 '-g',
2856 ], 2868 ],
(...skipping 1765 matching lines...) Expand 10 before | Expand all | Expand 10 after
4622 # settings in target dicts. SYMROOT is a special case, because many other 4634 # settings in target dicts. SYMROOT is a special case, because many other
4623 # Xcode variables depend on it, including variables such as 4635 # Xcode variables depend on it, including variables such as
4624 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4636 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4625 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4637 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4626 # files to appear (when present) in the UI as actual files and not red 4638 # files to appear (when present) in the UI as actual files and not red
4627 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4639 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4628 # and therefore SYMROOT, needs to be set at the project level. 4640 # and therefore SYMROOT, needs to be set at the project level.
4629 'SYMROOT': '<(DEPTH)/xcodebuild', 4641 'SYMROOT': '<(DEPTH)/xcodebuild',
4630 }, 4642 },
4631 } 4643 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698