Issue 18477006: Do not turn on --fatal-warnings for android_webview_build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18477006: Do not turn on --fatal-warnings for android_webview_build (Closed)

Created:
7 years, 5 months ago by mnaganov (inactive)

Modified:
7 years, 5 months ago

Reviewers:
shashi, Torne

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do not turn on --fatal-warnings for android_webview_build This fixes Android WebView build after https://crrev.com/17820002/ BUG=157326 TBR=torne,shashi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209934

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	build/common.gypi	View		2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

Committed patchset #1 manually as r209934 (presubmit successful).

7 years, 5 months ago (2013-07-03 08:58:55 UTC) #1

shashi

7 years, 5 months ago (2013-07-03 12:02:30 UTC) #2

Message was sent while issue was closed.

On 2013/07/03 08:58:55, Mikhail Naganov (Chromium) wrote:
> Committed patchset #1 manually as r209934 (presubmit successful).
Sorry about that and thank you for the fix.

Expand Messages | Collapse Messages