third_party/WebKit/Source/core/editing/InputMethodController.h - Issue 1847583003: Fix setComposingText when newCursorPosition != 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.h

Issue 1847583003: Fix setComposingText when newCursorPosition != 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add some C++ unit tests. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/InputMethodController.h

diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.h b/third_party/WebKit/Source/core/editing/InputMethodController.h

index 8936994873c3260034fcf2f0b74084ad7c634fcf..46573529b4b02926119b90affd38ee102f8303b8 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodController.h

+++ b/third_party/WebKit/Source/core/editing/InputMethodController.h

@@ -55,7 +55,7 @@ public:

// international text input composition

bool hasComposition() const;

- void setComposition(const String&, const Vector<CompositionUnderline>&, unsigned selectionStart, unsigned selectionEnd);

+ void setComposition(const String&, const Vector<CompositionUnderline>&, int selectionStart, int selectionEnd);

void setCompositionFromExistingText(const Vector<CompositionUnderline>&, unsigned compositionStart, unsigned compositionEnd);

// Inserts the text that is being composed as a regular text and returns true

// if composition exists.