third_party/WebKit/Source/core/editing/InputMethodController.h - Issue 1847583003: Fix setComposingText when newCursorPosition != 1

Side by Side Diff: third_party/WebKit/Source/core/editing/InputMethodController.h

Issue 1847583003: Fix setComposingText when newCursorPosition != 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add some C++ unit tests. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('K') | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('j') | third_party/WebKit/Source/core/editing/PlainTextRange.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 DoNotKeepSelection,	48 DoNotKeepSelection,

49 KeepSelection,	49 KeepSelection,

50 };	50 };

51	51

52 static RawPtr<InputMethodController> create(LocalFrame&);	52 static RawPtr<InputMethodController> create(LocalFrame&);

53 ~InputMethodController();	53 ~InputMethodController();

54 DECLARE_TRACE();	54 DECLARE_TRACE();

55	55

56 // international text input composition	56 // international text input composition

57 bool hasComposition() const;	57 bool hasComposition() const;

58 void setComposition(const String&, const Vector<CompositionUnderline>&, unsi gned selectionStart, unsigned selectionEnd);	58 void setComposition(const String&, const Vector<CompositionUnderline>&, int selectionStart, int selectionEnd);

59 void setCompositionFromExistingText(const Vector<CompositionUnderline>&, uns igned compositionStart, unsigned compositionEnd);	59 void setCompositionFromExistingText(const Vector<CompositionUnderline>&, uns igned compositionStart, unsigned compositionEnd);

60 // Inserts the text that is being composed as a regular text and returns tru e	60 // Inserts the text that is being composed as a regular text and returns tru e

61 // if composition exists.	61 // if composition exists.

62 bool confirmComposition();	62 bool confirmComposition();

63 // Inserts the given text string in the place of the existing composition	63 // Inserts the given text string in the place of the existing composition

64 // and returns true.	64 // and returns true.

65 bool confirmComposition(const String& text, ConfirmCompositionBehavior confi rmBehavior = KeepSelection);	65 bool confirmComposition(const String& text, ConfirmCompositionBehavior confi rmBehavior = KeepSelection);

66 // Inserts the text that is being composed or specified non-empty text and	66 // Inserts the text that is being composed or specified non-empty text and

67 // returns true.	67 // returns true.

68 bool confirmCompositionOrInsertText(const String& text, ConfirmCompositionBe havior);	68 bool confirmCompositionOrInsertText(const String& text, ConfirmCompositionBe havior);

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
109	109

110 String composingText() const;	110 String composingText() const;

111 bool insertTextForConfirmedComposition(const String& text);	111 bool insertTextForConfirmedComposition(const String& text);

112 void selectComposition() const;	112 void selectComposition() const;

113 bool setSelectionOffsets(const PlainTextRange&);	113 bool setSelectionOffsets(const PlainTextRange&);

114 };	114 };

115	115

116 } // namespace blink	116 } // namespace blink

117	117

118 #endif // InputMethodController_h	118 #endif // InputMethodController_h

OLD	NEW