third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp - Issue 1847583003: Fix setComposingText when newCursorPosition != 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

Issue 1847583003: Fix setComposingText when newCursorPosition != 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Modified some C++ unit tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/InputMethodController.cpp ('k') | third_party/WebKit/Source/core/editing/PlainTextRange.cpp » ('j') | third_party/WebKit/Source/core/editing/PlainTextRange.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

index 8378cfd7faeab0d62587fa4938265288c6028f32..25482698c447dda0f0ecea36f7148ee0807bb6f1 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

@@ -174,7 +174,10 @@ TEST_F(InputMethodControllerTest, SetCompositionFromExistingTextWithInvalidOffse

underlines.append(CompositionUnderline(7, 8, Color(255, 0, 0), false, 0));

controller().setCompositionFromExistingText(underlines, 7, 8);

- EXPECT_FALSE(controller().compositionRange());

+ // If it exceeds the right boundary, it should stay at the right boundary

+ RawPtr<Range> range = controller().compositionRange();

+ EXPECT_EQ(6, range->startOffset());

+ EXPECT_EQ(6, range->endOffset());

Changwan Ryu 2016/04/05 07:50:37 I think you need more tests, e.g. (-1, 8), (-4, -2

yabinh 2016/04/05 08:06:41 Acknowledged.

}

TEST_F(InputMethodControllerTest, ConfirmPasswordComposition)