Fix setComposingText when newCursorPosition != 1

third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/InputMethodController.h"
 
 #include "core/dom/Element.h"
 #include "core/dom/Range.h"
 #include "core/editing/FrameSelection.h"
 #include "core/frame/LocalFrame.h"
@@ skipping 156 matching lines @@
 }
 
 TEST_F(InputMethodControllerTest, SetCompositionFromExistingTextWithInvalidOffsets)
 {
     insertHTMLElement("<div id='sample' contenteditable='true'>test</div>", "sample");
 
     Vector<CompositionUnderline> underlines;
     underlines.append(CompositionUnderline(7, 8, Color(255, 0, 0), false, 0));
     controller().setCompositionFromExistingText(underlines, 7, 8);
 
-    EXPECT_FALSE(controller().compositionRange());
+    // If it exceeds the right boundary, it should stay at the right boundary
+    RawPtr<Range> range = controller().compositionRange();
+    EXPECT_EQ(6, range->startOffset());
+    EXPECT_EQ(6, range->endOffset());

[Changwan Ryu, 2016/04/05 07:50:37]

I think you need more tests, e.g. (-1, 8), (-4, -2), (3, 8)

[yabinh, 2016/04/05 08:06:41]

Acknowledged.

 }
 
 TEST_F(InputMethodControllerTest, ConfirmPasswordComposition)
 {
     HTMLInputElement* input = toHTMLInputElement(
         insertHTMLElement("<input id='sample' type='password' size='24'>", "sample"));
 
     Vector<CompositionUnderline> underlines;
     underlines.append(CompositionUnderline(0, 5, Color(255, 0, 0), false, 0));
     controller().setComposition("foo", underlines, 0, 3);
     controller().confirmComposition();
 
     EXPECT_STREQ("foo", input->value().utf8().data());
 }
 
 } // namespace blink