Expose a lower bound of malloc'd memory via heap statistics

Expose a lower bound of malloc'd memory via heap statistics

We expect that the majority of malloc'd memory held by V8 is allocated
in Zone objects. Introduce an Allocator class that is used by Zones to
manage memory, and allows for querying the current usage.

BUG=none
R=titzer@chromium.org,bmeurer@chromium.org,jarin@chromium.org
LOG=n
TBR=rossberg@chromium.org

Committed: https://crrev.com/cb7aa79b1265b09e21a82d31d4c60470a4444fa5
Cr-Commit-Position: refs/heads/master@{#35196}

[jochen (gone - plz use gerrit), 2016-03-30 15:03:29]

ptal

Instead of having the counter on the isolate, I'm introducing a separate class
to do the accounting.

For testing and for type-cache, I use a separate allocator, for the rest, we use
an per-isolate allocator.

[jochen (gone - plz use gerrit), 2016-03-31 11:28:31]

updated the name to AccountingAllocator after offline discussion with Ben

[titzer, 2016-03-31 11:49:30]

https://codereview.chromium.org/1847543002/diff/60001/test/cctest/compiler/fu...
File test/cctest/compiler/function-tester.h (right):

https://codereview.chromium.org/1847543002/diff/60001/test/cctest/compiler/fu...
test/cctest/compiler/function-tester.h:178: Zone
zone(function->GetIsolate()->allocator());
Can we have a TestZone with a no arg constructor that has its own allocator
built in? The fewer uses of isolate in tests, the better.

[jochen (gone - plz use gerrit), 2016-04-01 08:17:20]

jochen@chromium.org changed reviewers:
+ rossberg@chromium.org

[jochen (gone - plz use gerrit), 2016-04-01 08:17:21]

+rossberg for src/parsing

ptal

[Benedikt Meurer, 2016-04-01 09:00:01]

bmeurer@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Benedikt Meurer, 2016-04-01 09:00:01]

bmeurer@chromium.org changed required reviewers:
+ mstarzinger@chromium.org

[Benedikt Meurer, 2016-04-01 09:00:03]

LGTM once comments addressed.

https://codereview.chromium.org/1847543002/diff/60001/test/unittests/wasm/enc...
File test/unittests/wasm/encoder-unittest.cc (right):

https://codereview.chromium.org/1847543002/diff/60001/test/unittests/wasm/enc...
test/unittests/wasm/encoder-unittest.cc:55: base::AccountingAllocator allocator;
I like this one better. No ZoneForTesting and keep Zone final, plus no surprise
when actually accessing the allocator in the Zone constructor.

https://codereview.chromium.org/1847543002/diff/80001/src/base/accounting_all...
File src/base/accounting_allocator.cc (right):

https://codereview.chromium.org/1847543002/diff/80001/src/base/accounting_all...
src/base/accounting_allocator.cc:1: // Copyright 2016 the V8 project authors.
All rights reserved.
Nit: accounting-allocator.{h,cc}

https://codereview.chromium.org/1847543002/diff/80001/src/base/accounting_all...
src/base/accounting_allocator.cc:7: #include <stdlib.h>
Nit: cstdlib

[Michael Starzinger, 2016-04-01 09:15:52]

LGTM. Not a huge fan of having a parameter in the Zone constructor again, but I
don't see an alternative/better way to get the per-Isolate accounting working.

https://codereview.chromium.org/1847543002/diff/60001/test/unittests/wasm/enc...
File test/unittests/wasm/encoder-unittest.cc (right):

https://codereview.chromium.org/1847543002/diff/60001/test/unittests/wasm/enc...
test/unittests/wasm/encoder-unittest.cc:55: base::AccountingAllocator allocator;
On 2016/04/01 09:00:03, Benedikt Meurer wrote:
> I like this one better. No ZoneForTesting and keep Zone final, plus no
surprise
> when actually accessing the allocator in the Zone constructor.

Slightly prefer being explicit in the tests as well, but am fine either way.

https://codereview.chromium.org/1847543002/diff/80001/src/base/accounting_all...
File src/base/accounting_allocator.cc (right):

https://codereview.chromium.org/1847543002/diff/80001/src/base/accounting_all...
src/base/accounting_allocator.cc:1: // Copyright 2016 the V8 project authors.
All rights reserved.
On 2016/04/01 09:00:03, Benedikt Meurer wrote:
> Nit: accounting-allocator.{h,cc}

+1

[jochen (gone - plz use gerrit), 2016-04-01 09:28:23]

all comments addressed

[titzer, 2016-04-01 09:31:23]

On 2016/04/01 09:28:23, jochen wrote:
> all comments addressed

lgtm

[jochen (gone - plz use gerrit), 2016-04-01 09:32:56]

Description was changed from

==========
Expose a lower bound of malloc'd memory via heap statistics

We expect that the majority of malloc'd memory held by V8 is allocated
in Zone objects. Introduce an Allocator class that is used by Zones to
manage memory, and allows for querying the current usage.

BUG=none
R=titzer@chromium.org,bmeurer@chromium.org,jarin@chromium.org
LOG=n
==========

to

==========
Expose a lower bound of malloc'd memory via heap statistics

We expect that the majority of malloc'd memory held by V8 is allocated
in Zone objects. Introduce an Allocator class that is used by Zones to
manage memory, and allows for querying the current usage.

BUG=none
R=titzer@chromium.org,bmeurer@chromium.org,jarin@chromium.org
LOG=n
TBR=rossberg@chromium.org
==========

[jochen (gone - plz use gerrit), 2016-04-01 09:33:15]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-04-01 09:33:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1847543002/#ps100001
(title: "updates")

[commit-bot: I haz the power, 2016-04-01 09:33:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847543002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847543002/100001

[commit-bot: I haz the power, 2016-04-01 10:00:38]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-01 10:02:05]

Description was changed from

==========
Expose a lower bound of malloc'd memory via heap statistics

We expect that the majority of malloc'd memory held by V8 is allocated
in Zone objects. Introduce an Allocator class that is used by Zones to
manage memory, and allows for querying the current usage.

BUG=none
R=titzer@chromium.org,bmeurer@chromium.org,jarin@chromium.org
LOG=n
TBR=rossberg@chromium.org
==========

to

==========
Expose a lower bound of malloc'd memory via heap statistics

We expect that the majority of malloc'd memory held by V8 is allocated
in Zone objects. Introduce an Allocator class that is used by Zones to
manage memory, and allows for querying the current usage.

BUG=none
R=titzer@chromium.org,bmeurer@chromium.org,jarin@chromium.org
LOG=n
TBR=rossberg@chromium.org

Committed: https://crrev.com/cb7aa79b1265b09e21a82d31d4c60470a4444fa5
Cr-Commit-Position: refs/heads/master@{#35196}
==========

[commit-bot: I haz the power, 2016-04-01 10:02:07]

Patchset 6 (id:??) landed as
https://crrev.com/cb7aa79b1265b09e21a82d31d4c60470a4444fa5
Cr-Commit-Position: refs/heads/master@{#35196}