Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2248)

Unified Diff: test/unittests/wasm/ast-decoder-unittest.cc

Issue 1847543002: Expose a lower bound of malloc'd memory via heap statistics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/test-utils.h ('k') | test/unittests/wasm/encoder-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/wasm/ast-decoder-unittest.cc
diff --git a/test/unittests/wasm/ast-decoder-unittest.cc b/test/unittests/wasm/ast-decoder-unittest.cc
index ae1d3585dfbf6508e6460b98dd85a074da9204ce..99af72998aae077ab9806e5c70c80b670ec8d31b 100644
--- a/test/unittests/wasm/ast-decoder-unittest.cc
+++ b/test/unittests/wasm/ast-decoder-unittest.cc
@@ -80,7 +80,8 @@ class AstDecoderTest : public TestWithZone {
const byte* end) {
local_decls.Prepend(&start, &end);
// Verify the code.
- TreeResult result = VerifyWasmCode(module, sig, start, end);
+ TreeResult result =
+ VerifyWasmCode(zone()->allocator(), module, sig, start, end);
if (result.error_code != expected) {
ptrdiff_t pc = result.error_pc - result.start;
@@ -2211,7 +2212,9 @@ class LocalDeclDecoderTest : public TestWithZone {
TEST_F(LocalDeclDecoderTest, NoLocals) {
static const byte data[] = {0};
- LocalTypeMap map = DecodeLocalDeclsForTesting(data, data + sizeof(data));
+ base::AccountingAllocator allocator;
+ LocalTypeMap map =
+ DecodeLocalDeclsForTesting(&allocator, data, data + sizeof(data));
EXPECT_EQ(0, map->size());
if (map) delete map;
}
@@ -2221,7 +2224,9 @@ TEST_F(LocalDeclDecoderTest, OneLocal) {
LocalType type = kLocalTypes[i];
const byte data[] = {
1, 1, static_cast<byte>(WasmOpcodes::LocalTypeCodeFor(type))};
- LocalTypeMap map = DecodeLocalDeclsForTesting(data, data + sizeof(data));
+ base::AccountingAllocator allocator;
+ LocalTypeMap map =
+ DecodeLocalDeclsForTesting(&allocator, data, data + sizeof(data));
EXPECT_EQ(1, map->size());
EXPECT_EQ(type, map->at(0));
if (map) delete map;
@@ -2233,7 +2238,9 @@ TEST_F(LocalDeclDecoderTest, FiveLocals) {
LocalType type = kLocalTypes[i];
const byte data[] = {
1, 5, static_cast<byte>(WasmOpcodes::LocalTypeCodeFor(type))};
- LocalTypeMap map = DecodeLocalDeclsForTesting(data, data + sizeof(data));
+ base::AccountingAllocator allocator;
+ LocalTypeMap map =
+ DecodeLocalDeclsForTesting(&allocator, data, data + sizeof(data));
EXPECT_EQ(5, map->size());
ExpectRun(map, 0, type, 5);
if (map) delete map;
@@ -2247,8 +2254,9 @@ TEST_F(LocalDeclDecoderTest, MixedLocals) {
for (byte d = 0; d < 3; d++) {
const byte data[] = {4, a, kLocalI32, b, kLocalI64,
c, kLocalF32, d, kLocalF64};
+ base::AccountingAllocator allocator;
LocalTypeMap map =
- DecodeLocalDeclsForTesting(data, data + sizeof(data));
+ DecodeLocalDeclsForTesting(&allocator, data, data + sizeof(data));
EXPECT_EQ(a + b + c + d, map->size());
size_t pos = 0;
@@ -2274,7 +2282,8 @@ TEST_F(LocalDeclDecoderTest, UseEncoder) {
local_decls.AddLocals(212, kAstI64);
local_decls.Prepend(&data, &end);
- LocalTypeMap map = DecodeLocalDeclsForTesting(data, end);
+ base::AccountingAllocator allocator;
+ LocalTypeMap map = DecodeLocalDeclsForTesting(&allocator, data, end);
size_t pos = 0;
pos = ExpectRun(map, pos, kAstF32, 5);
pos = ExpectRun(map, pos, kAstI32, 1337);
« no previous file with comments | « test/unittests/test-utils.h ('k') | test/unittests/wasm/encoder-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698