Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1847493002: [X87] [TurboFan] Fix Float32ToFloat64 code generation bug. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[X87] [TurboFan] Fix Float32ToFloat64 code generation bug. The CL #34967 (https://codereview.chromium.org/1804243003) and CL #35045 (https://codereview.chromium.org/1825333004) exposed one hidden bug in x87 turbofan code generation for Float32ToFloat64. This CL fixed this bug. BUG= Committed: https://crrev.com/75602673e61bd6f1f1963700927c7b7b1f4cab24 Cr-Commit-Position: refs/heads/master@{#35129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-03-30 08:30:43 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-03-30 09:07:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847493002/1
4 years, 8 months ago (2016-03-30 09:08:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 09:32:33 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 09:34:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75602673e61bd6f1f1963700927c7b7b1f4cab24
Cr-Commit-Position: refs/heads/master@{#35129}

Powered by Google App Engine
This is Rietveld 408576698