Fix conversion to float32, typing issue, split apart asm-wasm tests.

Fix conversion to float32, typing issue, split apart asm-wasm tests.

Add missing conversions from other types to f32 in fround.
Restrict fround() to only float, double, signed, unsigned (no unions / intish).
Restrict Bitwise operations to intish, particularly |0, when not applied to a foreign function.

Adding more exhaustive tests of stdlib Math, move to a separate file.
Adding tests of interesting values for the stdlib asm.js functions.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N

Committed: https://crrev.com/cca5c3f630df67b80f96c59ba4c9369428ba8000
Cr-Commit-Position: refs/heads/master@{#34967}

[bradn, 2016-03-16 01:27:33]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradnelson, 2016-03-16 05:09:45]

Sorry, sent out too soon, not quite ready for review, float checking issue.

(You have a problem, you decide to use floating point, now you have 1.9999999
problems. :-(

[titzer, 2016-03-16 09:44:05]

https://codereview.chromium.org/1804243003/diff/40001/test/mjsunit/wasm/asm-w...
File test/mjsunit/wasm/asm-wasm-stdlib.js (right):

https://codereview.chromium.org/1804243003/diff/40001/test/mjsunit/wasm/asm-w...
test/mjsunit/wasm/asm-wasm-stdlib.js:275: 0, -0, 1, -1, 0.9, -0.9, 1.414, 0x7F,
-0x80, -0x8000, -0x80000000,
Not sure if it matters here but 0.9 is not exactly representable in floating
point. In these cases I usually pick a fractional number like 0.25, 0.125, etc.

https://codereview.chromium.org/1804243003/diff/40001/test/mjsunit/wasm/asm-w...
test/mjsunit/wasm/asm-wasm-stdlib.js:284: 'i32': function(x) { return x | 0; },
You can drop the single quotes from these property names.

[bradn, 2016-03-16 19:01:49]

Patchset #4 (id:60001) has been deleted

[bradnelson, 2016-03-18 23:35:53]

Description was changed from

==========
Adding more exhaustive tests of stdlib Math, move to a separate file.

Adding tests of interesting values for the stdlib asm.js functions.
This uncovered small issues with the asm-wasm-builder, to be resolved
in a separate change.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N
==========

to

==========
Fix conversion to float32, typing issue, split apart asm-wasm tests.

Add missing conversions from other types to f32 in fround.

Adding more exhaustive tests of stdlib Math, move to a separate file.

Adding tests of interesting values for the stdlib asm.js functions.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N
==========

[bradnelson, 2016-03-18 23:38:26]

Description was changed from

==========
Fix conversion to float32, typing issue, split apart asm-wasm tests.

Add missing conversions from other types to f32 in fround.

Adding more exhaustive tests of stdlib Math, move to a separate file.

Adding tests of interesting values for the stdlib asm.js functions.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N
==========

to

==========
Fix conversion to float32, typing issue, split apart asm-wasm tests.

Add missing conversions from other types to f32 in fround.

Restrict fround() to only float, double, signed, unsigned (no unions / intish).

Restrict Bitwise operations to intish, particularly |0, when not applied to a
foreign function.

Adding more exhaustive tests of stdlib Math, move to a separate file.

Adding tests of interesting values for the stdlib asm.js functions.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N
==========

[bradnelson, 2016-03-18 23:41:52]

Description was changed from

==========
Fix conversion to float32, typing issue, split apart asm-wasm tests.

Add missing conversions from other types to f32 in fround.

Restrict fround() to only float, double, signed, unsigned (no unions / intish).

Restrict Bitwise operations to intish, particularly |0, when not applied to a
foreign function.

Adding more exhaustive tests of stdlib Math, move to a separate file.

Adding tests of interesting values for the stdlib asm.js functions.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N
==========

to

==========
Fix conversion to float32, typing issue, split apart asm-wasm tests.

Add missing conversions from other types to f32 in fround.
Restrict fround() to only float, double, signed, unsigned (no unions / intish).
Restrict Bitwise operations to intish, particularly |0, when not applied to a
foreign function.

Adding more exhaustive tests of stdlib Math, move to a separate file.
Adding tests of interesting values for the stdlib asm.js functions.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N
==========

[bradnelson, 2016-03-19 03:48:48]

PTAL

https://codereview.chromium.org/1804243003/diff/40001/test/mjsunit/wasm/asm-w...
File test/mjsunit/wasm/asm-wasm-stdlib.js (right):

https://codereview.chromium.org/1804243003/diff/40001/test/mjsunit/wasm/asm-w...
test/mjsunit/wasm/asm-wasm-stdlib.js:275: 0, -0, 1, -1, 0.9, -0.9, 1.414, 0x7F,
-0x80, -0x8000, -0x80000000,
On 2016/03/16 09:44:05, titzer wrote:
> Not sure if it matters here but 0.9 is not exactly representable in floating
> point. In these cases I usually pick a fractional number like 0.25, 0.125,
etc.

Got these "edge case" values from the simd tests. Added the exact ones you
specify, but kept these, since js should canonically convert them.

I've made the comparisons with float strict except for a few like cos/sin/exp,
where fdlib has a different approximation than you get through other paths.

By the way the SIMD folks expressed the belief that math ops returning different
values based on optimization level is bad at some point. Though I don't believe
any verbiage to that effect got in the spec. JS is well... generous.

https://codereview.chromium.org/1804243003/diff/40001/test/mjsunit/wasm/asm-w...
test/mjsunit/wasm/asm-wasm-stdlib.js:284: 'i32': function(x) { return x | 0; },
On 2016/03/16 09:44:05, titzer wrote:
> You can drop the single quotes from these property names.

Done.

[titzer, 2016-03-21 07:59:44]

lgtm other than small comments

https://codereview.chromium.org/1804243003/diff/220001/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1804243003/diff/220001/src/typing-asm.cc#newc...
src/typing-asm.cc:992: if (!args->at(0)->bounds().upper->Is(cache_.kAsmFloat) &&
Cache args->at(0)->bounds().upper?

https://codereview.chromium.org/1804243003/diff/220001/src/wasm/asm-wasm-buil...
File src/wasm/asm-wasm-builder.cc (right):

https://codereview.chromium.org/1804243003/diff/220001/src/wasm/asm-wasm-buil...
src/wasm/asm-wasm-builder.cc:1003:
current_function_builder_->Emit(kExprF32SConvertI32);
These won't be semantically correct due to WASM, so please drop in a TODO in
wasm-compiler.cc that it needs to handle the asm.js case.

[bradn, 2016-03-21 20:31:08]

https://codereview.chromium.org/1804243003/diff/220001/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1804243003/diff/220001/src/typing-asm.cc#newc...
src/typing-asm.cc:992: if (!args->at(0)->bounds().upper->Is(cache_.kAsmFloat) &&
On 2016/03/21 07:59:44, titzer wrote:
> Cache args->at(0)->bounds().upper?

Done.

https://codereview.chromium.org/1804243003/diff/220001/src/wasm/asm-wasm-buil...
File src/wasm/asm-wasm-builder.cc (right):

https://codereview.chromium.org/1804243003/diff/220001/src/wasm/asm-wasm-buil...
src/wasm/asm-wasm-builder.cc:1003:
current_function_builder_->Emit(kExprF32SConvertI32);
On 2016/03/21 07:59:44, titzer wrote:
> These won't be semantically correct due to WASM, so please drop in a TODO in
> wasm-compiler.cc that it needs to handle the asm.js case.

I think these are ok as is (or have I forgotten something?). The other direction
requires special care, but that already appears to be there.

Added TODOs. Will discuss separately.

[bradn, 2016-03-21 20:31:13]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-03-21 20:31:13]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1804243003/#ps300001
(title: "fix")

[commit-bot: I haz the power, 2016-03-21 20:31:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1804243003/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1804243003/300001

[commit-bot: I haz the power, 2016-03-21 20:33:57]

Description was changed from

==========
Fix conversion to float32, typing issue, split apart asm-wasm tests.

Add missing conversions from other types to f32 in fround.
Restrict fround() to only float, double, signed, unsigned (no unions / intish).
Restrict Bitwise operations to intish, particularly |0, when not applied to a
foreign function.

Adding more exhaustive tests of stdlib Math, move to a separate file.
Adding tests of interesting values for the stdlib asm.js functions.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N
==========

to

==========
Fix conversion to float32, typing issue, split apart asm-wasm tests.

Add missing conversions from other types to f32 in fround.
Restrict fround() to only float, double, signed, unsigned (no unions / intish).
Restrict Bitwise operations to intish, particularly |0, when not applied to a
foreign function.

Adding more exhaustive tests of stdlib Math, move to a separate file.
Adding tests of interesting values for the stdlib asm.js functions.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N
==========

[commit-bot: I haz the power, 2016-03-21 20:33:58]

Committed patchset #15 (id:300001)

[commit-bot: I haz the power, 2016-03-21 20:34:49]

Description was changed from

==========
Fix conversion to float32, typing issue, split apart asm-wasm tests.

Add missing conversions from other types to f32 in fround.
Restrict fround() to only float, double, signed, unsigned (no unions / intish).
Restrict Bitwise operations to intish, particularly |0, when not applied to a
foreign function.

Adding more exhaustive tests of stdlib Math, move to a separate file.
Adding tests of interesting values for the stdlib asm.js functions.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N
==========

to

==========
Fix conversion to float32, typing issue, split apart asm-wasm tests.

Add missing conversions from other types to f32 in fround.
Restrict fround() to only float, double, signed, unsigned (no unions / intish).
Restrict Bitwise operations to intish, particularly |0, when not applied to a
foreign function.

Adding more exhaustive tests of stdlib Math, move to a separate file.
Adding tests of interesting values for the stdlib asm.js functions.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
TEST=test-asm-validator,asm-wasm
R=titzer@chromium.org,rossberg@chromium.org
LOG=N

Committed: https://crrev.com/cca5c3f630df67b80f96c59ba4c9369428ba8000
Cr-Commit-Position: refs/heads/master@{#34967}
==========

[commit-bot: I haz the power, 2016-03-21 20:34:50]

Patchset 15 (id:??) landed as
https://crrev.com/cca5c3f630df67b80f96c59ba4c9369428ba8000
Cr-Commit-Position: refs/heads/master@{#34967}