CREDENTIAL: Rework the integration with Fetch (2/2)

CREDENTIAL: Hide POSTed credentials from service workers.

Using the attached credential concept added in the patch at
https://codereview.chromium.org/1844053003, this patch teaches the
machinery in //content about the two request bodies exposed by
WebURLRequest, and passes an empty body into the Service Worker
handler when a credential is present.

BUG=599597

[Mike West, 2016-04-01 12:27:05]

mkwst@chromium.org changed reviewers:
+ horo@chromium.org, jochen@chromium.org, philipj@opera.com,
tyoshino@chromium.org

[Mike West, 2016-04-01 12:27:06]

Hello, lovely folks who are reviewing
https://codereview.chromium.org/1844053003, and should certainly be given an
opportunity to review this follow-on CL as well! WDYT? :)

-mike

[horo, 2016-04-04 05:32:17]

https://codereview.chromium.org/1847383003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch-serviceworker.html
(right):

https://codereview.chromium.org/1847383003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch-serviceworker.html:25:
.then(_ => service_worker_unregister_and_done(t, scope));
Nit: Remove trailing whitespace.

https://codereview.chromium.org/1847383003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch-serviceworker.html:30:
return with_iframe(scope)
You have to register the Service Worker before calling with_iframe().
This test is executed without the Service Worker.

https://codereview.chromium.org/1847383003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch-serviceworker.html:32:
.then(_ => service_worker_unregister_and_done(t, scope));
Nit: Remove trailing whitespace.

https://codereview.chromium.org/1847383003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/fetch-serviceworker.html
(right):

https://codereview.chromium.org/1847383003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/fetch-serviceworker.html:35:
}
Please add tests for
1. e.respondWith(fetch(e.request))
2. e.respondWith(fetch(e.request.clone()))

[philipj_slow, 2016-04-06 13:33:00]

Took a look at the tests, all nice and tidy, I'll leave the rest to horo@

https://codereview.chromium.org/1847383003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/fetch-serviceworker.html
(right):

https://codereview.chromium.org/1847383003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/fetch-serviceworker.html:15:
reject("Credentials was '" + j.credentials + "'");
Since you're using fancy new arrow functions, you may also be interested in
`Credentials was '${j.credentials}'` which is pretty much made for this kind of
situation.

[tyoshino (SeeGerritForStatus), 2016-04-12 16:30:25]

.cpp .h lgtm

https://codereview.chromium.org/1847383003/diff/20001/content/child/web_url_l...
File content/child/web_url_loader_impl_unittest.cc (right):

https://codereview.chromium.org/1847383003/diff/20001/content/child/web_url_l...
content/child/web_url_loader_impl_unittest.cc:623:
request.setURL(GURL(kTestURL));
order these two lines the same as EmptyBodyInServiceWorkerNoCredential unless
needed

[jochen (gone - plz use gerrit), 2016-04-12 18:56:18]

lgtm