third_party/WebKit/Source/platform/exported/WebURLRequest.cpp - Issue 1847383003: CREDENTIAL: Rework the integration with Fetch (2/2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebURLRequest.cpp

Issue 1847383003: CREDENTIAL: Rework the integration with Fetch (2/2) Base URL: https://chromium.googlesource.com/chromium/src.git@pass-serialized

Patch Set: unittest Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/fetch-serviceworker.html ('K') | « third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/respond-with-body.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebURLRequest.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp b/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp

index 9ada47013020f3d406deba1131e0839fa81b7253..3496af85a605e69da886a815a32c81f590d7c952 100644

--- a/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp

@@ -208,12 +208,6 @@ void WebURLRequest::visitHTTPHeaderFields(WebHTTPHeaderVisitor* visitor) const

WebHTTPBody WebURLRequest::httpBody() const

{

- // TODO(mkwst): This is wrong, as it means that we're producing the body

- // before any ServiceWorker has a chance to operate, which means we're

- // revealing data to the SW that we ought to be hiding. Baby steps.

- // https://crbug.com/599597

- if (m_private->m_resourceRequest->attachedCredentialBody())

- return WebHTTPBody(m_private->m_resourceRequest->attachedCredentialBody());

return WebHTTPBody(m_private->m_resourceRequest->httpBody());

}