PRESUBMIT.py - Issue 1847353003: Add presubmit check to enforce that we don't add "#pragma comment(lib" anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1847353003: Add presubmit check to enforce that we don't add "#pragma comment(lib" anymore. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git cl try Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 5621f9fd037151f6072d0ed06d0009e8efa9198d..705c511a194eba1d5e114a1d959ec57dc4852adc 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -270,6 +270,14 @@ _BANNED_CPP_FUNCTIONS = (

r'^base[\\\/]message_loop[\\\/].*',

+ (

+ '#pragma comment(lib,',

+ (

+ 'Specify libraries to link with in build files and not in the source.',

+ ),

+ True,

+ (),

+ ),

)

_IPC_ENUM_TRAITS_DEPRECATED = (

« no previous file with comments | « no previous file | no next file » | no next file with comments »