Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1346)

Side by Side Diff: PRESUBMIT.py

Issue 1847353003: Add presubmit check to enforce that we don't add "#pragma comment(lib" anymore. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl try Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 ( 263 (
264 'MessageLoopProxy is deprecated. ', 264 'MessageLoopProxy is deprecated. ',
265 'Please use SingleThreadTaskRunner or ThreadTaskRunnerHandle instead.' 265 'Please use SingleThreadTaskRunner or ThreadTaskRunnerHandle instead.'
266 ), 266 ),
267 True, 267 True,
268 ( 268 (
269 # Internal message_loop related code may still use it. 269 # Internal message_loop related code may still use it.
270 r'^base[\\\/]message_loop[\\\/].*', 270 r'^base[\\\/]message_loop[\\\/].*',
271 ), 271 ),
272 ), 272 ),
273 (
274 '#pragma comment(lib,',
275 (
276 'Specify libraries to link with in build files and not in the source.',
277 ),
278 True,
279 (),
280 ),
273 ) 281 )
274 282
275 _IPC_ENUM_TRAITS_DEPRECATED = ( 283 _IPC_ENUM_TRAITS_DEPRECATED = (
276 'You are using IPC_ENUM_TRAITS() in your code. It has been deprecated.\n' 284 'You are using IPC_ENUM_TRAITS() in your code. It has been deprecated.\n'
277 'See http://www.chromium.org/Home/chromium-security/education/security-tips- for-ipc') 285 'See http://www.chromium.org/Home/chromium-security/education/security-tips- for-ipc')
278 286
279 287
280 _VALID_OS_MACROS = ( 288 _VALID_OS_MACROS = (
281 # Please keep sorted. 289 # Please keep sorted.
282 'OS_ANDROID', 290 'OS_ANDROID',
(...skipping 1806 matching lines...) Expand 10 before | Expand all | Expand 10 after
2089 results.extend(input_api.canned_checks.CheckTreeIsOpen( 2097 results.extend(input_api.canned_checks.CheckTreeIsOpen(
2090 input_api, 2098 input_api,
2091 output_api, 2099 output_api,
2092 json_url='http://chromium-status.appspot.com/current?format=json')) 2100 json_url='http://chromium-status.appspot.com/current?format=json'))
2093 2101
2094 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2102 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2095 input_api, output_api)) 2103 input_api, output_api))
2096 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2104 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2097 input_api, output_api)) 2105 input_api, output_api))
2098 return results 2106 return results
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698