Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1847353003: Add presubmit check to enforce that we don't add "#pragma comment(lib" anymore. (Closed)

Created:
4 years, 8 months ago by jam
Modified:
4 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, asanka, nasko+codewatch_chromium.org, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, tapted, maniscalco+watch-blimp_chromium.org, Matt Giuca, lcwu+watch_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, halliwell+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, extensions-reviews_chromium.org, Peter Beverloo, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, tfarina, mkwst+moarreviews-renderer_chromium.org, dtrainor+watch-blimp_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add presubmit check to enforce that we don't add "#pragma comment(lib" anymore. BUG=597028 Committed: https://crrev.com/e2d1a95a4a7b352ec99be461a3e443d5ba7c859a Cr-Commit-Position: refs/heads/master@{#384754}

Patch Set 1 : #

Patch Set 2 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M PRESUBMIT.py View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847353003/20001
4 years, 8 months ago (2016-04-01 17:44:59 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 18:20:52 UTC) #5
jam
4 years, 8 months ago (2016-04-01 22:27:46 UTC) #7
Nico
Do we really need a presubmit for this? presubmits already take way too long to ...
4 years, 8 months ago (2016-04-01 22:40:56 UTC) #8
jam
On 2016/04/01 22:40:56, Nico wrote: > Do we really need a presubmit for this? presubmits ...
4 years, 8 months ago (2016-04-01 22:49:42 UTC) #9
Nico
I believe that too. I'm just wondering if 1-2 of these creeping back in per ...
4 years, 8 months ago (2016-04-01 22:57:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847353003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847353003/40001
4 years, 8 months ago (2016-04-01 23:34:57 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-04-02 00:27:20 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 00:28:28 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e2d1a95a4a7b352ec99be461a3e443d5ba7c859a
Cr-Commit-Position: refs/heads/master@{#384754}

Powered by Google App Engine
This is Rietveld 408576698