Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1847353002:
Reformat args lists in perftestsrunner_unittest.py. (Closed)
DescriptionReformat args lists in perftestsrunner_unittest.py.
Follow-up to https://codereview.chromium.org/1839193004.
Committed: https://crrev.com/e07d684a573c54c64f3e3b2da5b952add5c4ae62
Cr-Commit-Position: refs/heads/master@{#390287}
Patch Set 1 #
Messages
Total messages: 18 (7 generated)
qyearsley@chromium.org changed reviewers: + tansell@chromium.org
Were these the parts of this file that you were thinking could be reformatting in a follow-up CL? Was there somewhere else in this file where reformatting could improve readability?
On 2016/04/01 at 05:34:07, qyearsley wrote: > Were these the parts of this file that you were thinking could be reformatting in a follow-up CL? Was there somewhere else in this file where reformatting could improve readability? Hi Tim, does this CL still seem fine to submit, or should I close it?
The CQ bit was checked by tansell@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847353002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by tansell@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847353002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by tansell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847353002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e07d684a573c54c64f3e3b2da5b952add5c4ae62 Cr-Commit-Position: refs/heads/master@{#390287}
Message was sent while issue was closed.
Description was changed from ========== Reformat args lists in perftestsrunner_unittest.py. Follow-up to https://codereview.chromium.org/1839193004. ========== to ========== Reformat args lists in perftestsrunner_unittest.py. Follow-up to https://codereview.chromium.org/1839193004. Committed: https://crrev.com/e07d684a573c54c64f3e3b2da5b952add5c4ae62 Cr-Commit-Position: refs/heads/master@{#390287} ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
