Remove support for legacy WebKit Notifications

Remove support for legacy WebKit Notifications

This patch removes support for the legacy WebKit notifications from Blink,
per the following Intent to Remove thread:

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8vqyfHa8_dw

BUG=348019
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168471

[Peter Beverloo, 2014-02-28 17:24:51]

Still need one additional approval in the Intent to Remove thread, please hold
off with reviewing until the thread settles.

This patch:
    * Removes the layout tests which depend on legacy notifications.
    * Removes the legacy implementation from modules/notifications/.
    * Plumbs through s/NotificationBase/Notifications/ through the API.

Since it's already rather big, the following items will be addressed in
follow-up patches:
    * Write tests to bring the Notification layout test suite up to par again --
this is a P0 and will be addressed in the first few days of next week, but I'd
like to take the opportunity to do some clean-ups in the test-runner as well.
    * Clean up the Blink API, removing bits we don't need anymore, use accurate
names for the standards API (e.g. s/replaceId/tag/).
    * Clean up remaining TODOs and nits in modules/notifications/.

[abarth-chromium, 2014-03-01 06:23:49]

Code change LGTM.  Please wait for the blink-dev thread to converge before
landing.

https://codereview.chromium.org/184733002/diff/20001/Source/modules/notificat...
File Source/modules/notifications/Notification.cpp (right):

https://codereview.chromium.org/184733002/diff/20001/Source/modules/notificat...
Source/modules/notifications/Notification.cpp:176: // Do not dispatch if the
context is gone.
Can we ASSERT something about m_state here?  Maybe it's better to check m_state
rather than looking at executionContext directly.  executionContext might reveal
GC timing, but m_state should be predictable.

Obviously feel free to defer these comments to a future CL.

https://codereview.chromium.org/184733002/diff/20001/Source/web/WebNotificati...
File Source/web/WebNotification.cpp (right):

https://codereview.chromium.org/184733002/diff/20001/Source/web/WebNotificati...
Source/web/WebNotification.cpp:48: };
You can almost certainly delete WebNotificationPrivate.

https://codereview.chromium.org/184733002/diff/20001/public/web/WebNotificati...
File public/web/WebNotification.h (right):

https://codereview.chromium.org/184733002/diff/20001/public/web/WebNotificati...
public/web/WebNotification.h:108: WebNotificationPrivate* m_private;
You can probably change this to WebPrivatePtr<Notification>

[Peter Beverloo, 2014-03-04 18:41:58]

Thanks for the comments Adam! I'll do a complete run-through of the Blink code
after this CL lands; I'd like naming of methods and properties to be made
consistent as well (e.g. replaceId -> tag).

I've uploaded a series of CLs to address the loss in test coverage by removing
this, which is tracked in http://crbug.com/349015. The new tests should be
landable relatively quickly after this one.

The Intent to Remove thread got approval from Jochen, Adam and Eric.  As such,
let's put this on the commit queue!

[Peter Beverloo, 2014-03-04 18:42:43]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2014-03-04 18:43:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/peter@chromium.org/184733002/20001

[Andrew T Wilson (Slow), 2014-03-04 21:43:10]

BTW, not reviewing the actual code here since I'm distant enough from the Blink
codebase that I can't provide useful feedback. From an advisory/functional
standpoint, removing the legacy notification support LGTM.

[commit-bot: I haz the power, 2014-03-05 12:09:00]

Change committed as 168471

[Peter Beverloo, 2014-03-05 15:39:59]

A revert of this CL has been created in
https://codereview.chromium.org/187323005/ by peter@chromium.org.

The reason for reverting is: Broke interactive_ui_tests and browser_tests, as
pointed out by cbiesinger.

http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/35005.