Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2168)

Unified Diff: Source/modules/notifications/NotificationClient.h

Issue 184733002: Remove support for legacy WebKit Notifications (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove tests which no longer apply Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/notifications/NotificationClient.h
diff --git a/Source/modules/notifications/NotificationClient.h b/Source/modules/notifications/NotificationClient.h
index f918245534f06b2fb95ca25b29d9e59078fbbe83..e36dab92e00ad40b033346e731522ee7d69d1080 100644
--- a/Source/modules/notifications/NotificationClient.h
+++ b/Source/modules/notifications/NotificationClient.h
@@ -39,7 +39,7 @@
namespace WebCore {
class ExecutionContext;
-class NotificationBase;
+class Notification;
class NotificationClient {
@@ -51,22 +51,19 @@ public:
};
// Requests that a notification be shown.
- virtual bool show(NotificationBase*) = 0;
+ virtual bool show(Notification*) = 0;
// Requests that a notification that has already been shown be canceled.
- virtual void cancel(NotificationBase*) = 0;
+ virtual void cancel(Notification*) = 0;
// Informs the presenter that a Notification object has been destroyed
// (such as by a page transition). The presenter may continue showing
// the notification, but must not attempt to call the event handlers.
- virtual void notificationObjectDestroyed(NotificationBase*) = 0;
+ virtual void notificationObjectDestroyed(Notification*) = 0;
-#if ENABLE(LEGACY_NOTIFICATIONS)
// Requests user permission to show desktop notifications from a particular
// script context. The callback parameter should be run when the user has
// made a decision.
- virtual void requestPermission(ExecutionContext*, PassOwnPtr<VoidCallback>) = 0;
-#endif
virtual void requestPermission(ExecutionContext*, PassOwnPtr<NotificationPermissionCallback>) = 0;
// Checks the current level of permission.

Powered by Google App Engine
This is Rietveld 408576698