Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: public/platform/WebLayer.h

Issue 18473002: Add an API to report debugName in GraphicsLayer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: clear setName Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/WebLayer.h
diff --git a/public/platform/WebLayer.h b/public/platform/WebLayer.h
index a21ffedef919a12eec60ab09da0e9ccec60515e9..edcea5137bbdc03ae3310aa3378ffddd44f7217e 100644
--- a/public/platform/WebLayer.h
+++ b/public/platform/WebLayer.h
@@ -48,7 +48,15 @@ struct WebFloatRect;
struct WebLayerPositionConstraint;
struct WebSize;
-class WebLayerImpl;
+class WebLayer;
+
+class WebLayerClient {
enne (OOO) 2013/07/30 17:31:05 Can you put this interface in a separate file, lik
qiankun 2013/07/31 11:16:28 Done.
+ public:
enne (OOO) 2013/07/30 17:31:05 style nit: "public:" should be left-aligned and th
qiankun 2013/07/31 11:16:28 Done.
+ virtual WebString debugName(WebLayer*) { return WebString(); }
jamesr 2013/07/30 17:37:40 since this is going to be implemented inside Blink
qiankun 2013/07/31 11:16:28 Done.
+
+ protected:
+ virtual ~WebLayerClient() { }
+};
class WebLayer {
public:
@@ -213,6 +221,8 @@ public:
// True if the layer is not part of a tree attached to a WebLayerTreeView.
virtual bool isOrphan() const = 0;
+
+ virtual void setWebLayerClient(WebKit::WebLayerClient*) = 0;
jamesr 2013/07/30 17:37:40 Why is this a setter instead of being construction
qiankun 2013/07/31 11:16:28 WebLayer's client may not exist when the Weblayer
};
} // namespace WebKit
« Source/core/rendering/RenderLayerCompositor.cpp ('K') | « Source/core/rendering/RenderObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698