Add an API to report debugName in GraphicsLayer

public/platform/WebLayer.h

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 30 matching lines @@
 
 namespace WebKit {
 class WebAnimationDelegate;
 class WebFilterOperations;
 class WebLayerScrollClient;
 struct WebFloatPoint;
 struct WebFloatRect;
 struct WebLayerPositionConstraint;
 struct WebSize;
 
-class WebLayerImpl;
+class WebLayer;
+
+class WebLayerClient {

[enne (OOO), 2013/07/30 17:31:05]

Can you put this interface in a separate file, like WebLayerScrollClient and
WebContentLayerClient both are?

[qiankun, 2013/07/31 11:16:28]

Done.

+    public:

[enne (OOO), 2013/07/30 17:31:05]

style nit: "public:" should be left-aligned and the functions four-space
indented.  See WebLayer below.

[qiankun, 2013/07/31 11:16:28]

Done.

+        virtual WebString debugName(WebLayer*) { return WebString(); }

[jamesr, 2013/07/30 17:37:40]

since this is going to be implemented inside Blink, make it pure virtual

[qiankun, 2013/07/31 11:16:28]

Done.

+
+    protected:
+        virtual ~WebLayerClient() { }
+};
 
 class WebLayer {
 public:
     virtual ~WebLayer() { }
 
     // Returns a positive ID that will be unique across all WebLayers allocated in this process.
     virtual int id() const = 0;
 
     // Sets a region of the layer as invalid, i.e. needs to update its content.
     virtual void invalidateRect(const WebFloatRect&) = 0;
@@ skipping 144 matching lines @@
     // responsibility of the client to reset the layer's scroll client before
     // deleting the scroll client.
     virtual void setScrollClient(WebLayerScrollClient*) = 0;
 
     // Forces this layer to use a render surface. There is no benefit in doing
     // so, but this is to facilitate benchmarks and tests.
     virtual void setForceRenderSurface(bool) = 0;
 
     // True if the layer is not part of a tree attached to a WebLayerTreeView.
     virtual bool isOrphan() const = 0;
+
+    virtual void setWebLayerClient(WebKit::WebLayerClient*) = 0;

[jamesr, 2013/07/30 17:37:40]

Why is this a setter instead of being construction time?

[qiankun, 2013/07/31 11:16:28]

WebLayer's client may not exist when the Weblayer is created. Until
GraphicsLayer::setLinkHighlight() set m_linkHighlight and
GraphicsLayer::setupContentsLayer() set m_contentsLayer, we know the clients for
m_linkHighlight->layer() and m_contentsLayer. So, for such layers the setter is
required. 

 };
 
 } // namespace WebKit
 
 #endif // WebLayer_h