GN: Declare ARM build arguments for either target_cpu or current_cpu == "arm"

GN: Declare ARM build arguments for either target_cpu or current_cpu == "arm"

The change in crrev.com/d2eec2ae67e1494bb3a9aa7e0f1c1612298cccc0 fixed
crbug.com/592660 but caused crbug.com/599896.  The ARM build arguments are
relevant both in a build where target_cpu=="arm" and, in other builds, in
toolchain contexts where current_cpu=="arm".  For example, NaCl toolchains
for all different current_cpu values might be instantiated in a build where
target_cpu ist something else.

BUG=592660
BUG=599896
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
R=dpranke@chromium.org

Committed: https://crrev.com/9ad45bcd53fd0fe40c962ebff8dd7bc3b2d289c9
Cr-Commit-Position: refs/heads/master@{#384703}

[Roland McGrath, 2016-04-01 20:35:27]

The CQ bit was checked by mcgrathr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 20:35:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847063006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847063006/1

[Dirk Pranke, 2016-04-01 20:39:53]

I can see how this is probably the right fix, so, lgtm.

I would guess you'd hit an issue if host_cpu=="arm", but I don't think we
actually have any builders for that. Is there some nacl toolchain that also sets
current_cpu=="arm" that hit this?

It might be nice to list which toolchains hit this explicitly in the CL
description.

[Roland McGrath, 2016-04-01 20:57:57]

On 2016/04/01 20:39:53, Dirk Pranke wrote:
> I can see how this is probably the right fix, so, lgtm.
> 
> I would guess you'd hit an issue if host_cpu=="arm", but I don't think we
> actually have any builders for that. 

The issue would only come up if host_cpu=="arm" && host_cpu!=target_cpu built
something in a non-host toolchain that cared about ARM details.  It's hard to
imagine how that could come up (or should be allowed to).  For just
host_cpu=="arm" in the host toolchain context, current_cpu=="arm" so that is
covered by this change.

> Is there some nacl toolchain that also sets
> current_cpu=="arm" that hit this?
>
> It might be nice to list which toolchains hit this explicitly in the CL
> description.

I referenced crbug.com/599896, which is about the NaCl SDK build (build argument
nacl_sdk_untrusted=true, target nacl_sdk_core).
In the NaCl SDK build, target_cpu is whatever it is (always x64 in practice),
but it builds things in all of NaCl's untrusted toolchains, which includes two
where current_cpu=="arm".

[Roland McGrath, 2016-04-01 21:00:53]

Description was changed from

==========
GN: Declare ARM build arguments for either target_cpu or current_cpu == "arm"

The change in crrev.com/d2eec2ae67e1494bb3a9aa7e0f1c1612298cccc0 fixed
crbug.com/592660 but caused crbug.com/599896.  The ARM build arguments
are relevant both in a build where target_cpu=="arm" and, in other
builds, in toolchain contexts where current_cpu=="arm".

BUG=592660
BUG=599896
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
R=dpranke@chromium.org
==========

to

==========
GN: Declare ARM build arguments for either target_cpu or current_cpu == "arm"

The change in crrev.com/d2eec2ae67e1494bb3a9aa7e0f1c1612298cccc0 fixed
crbug.com/592660 but caused crbug.com/599896.  The ARM build arguments are
relevant both in a build where target_cpu=="arm" and, in other builds, in
toolchain contexts where current_cpu=="arm".  For example, NaCl toolchains
for all different current_cpu values might be instantiated in a build where
target_cpu ist something else.

BUG=592660
BUG=599896
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
R=dpranke@chromium.org
==========

[Dirk Pranke, 2016-04-01 21:02:05]

On 2016/04/01 20:57:57, Roland McGrath wrote:
> On 2016/04/01 20:39:53, Dirk Pranke wrote:
> > I can see how this is probably the right fix, so, lgtm.
> > 
> > I would guess you'd hit an issue if host_cpu=="arm", but I don't think we
> > actually have any builders for that. 
> 
> The issue would only come up if host_cpu=="arm" && host_cpu!=target_cpu built
> something in a non-host toolchain that cared about ARM details.  It's hard to
> imagine how that could come up (or should be allowed to).  For just
> host_cpu=="arm" in the host toolchain context, current_cpu=="arm" so that is
> covered by this change.

Yup. Sorry, I didn't make it clear that I was referring to the bug, not your
fix.
 
> > Is there some nacl toolchain that also sets
> > current_cpu=="arm" that hit this?
> >
> > It might be nice to list which toolchains hit this explicitly in the CL
> > description.
> 
> I referenced crbug.com/599896, which is about the NaCl SDK build (build
argument
> nacl_sdk_untrusted=true, target nacl_sdk_core).
> In the NaCl SDK build, target_cpu is whatever it is (always x64 in practice),
> but it builds things in all of NaCl's untrusted toolchains, which includes two
> where current_cpu=="arm".

Right, it was one of the NaCl untrusted toolchains I was thinking of.

[commit-bot: I haz the power, 2016-04-01 21:50:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 21:50:20]

Dry run: This issue passed the CQ dry run.

[Roland McGrath, 2016-04-01 21:52:49]

The CQ bit was checked by mcgrathr@chromium.org

[commit-bot: I haz the power, 2016-04-01 21:53:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847063006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847063006/1

[commit-bot: I haz the power, 2016-04-01 22:09:47]

Description was changed from

==========
GN: Declare ARM build arguments for either target_cpu or current_cpu == "arm"

The change in crrev.com/d2eec2ae67e1494bb3a9aa7e0f1c1612298cccc0 fixed
crbug.com/592660 but caused crbug.com/599896.  The ARM build arguments are
relevant both in a build where target_cpu=="arm" and, in other builds, in
toolchain contexts where current_cpu=="arm".  For example, NaCl toolchains
for all different current_cpu values might be instantiated in a build where
target_cpu ist something else.

BUG=592660
BUG=599896
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
R=dpranke@chromium.org
==========

to

==========
GN: Declare ARM build arguments for either target_cpu or current_cpu == "arm"

The change in crrev.com/d2eec2ae67e1494bb3a9aa7e0f1c1612298cccc0 fixed
crbug.com/592660 but caused crbug.com/599896.  The ARM build arguments are
relevant both in a build where target_cpu=="arm" and, in other builds, in
toolchain contexts where current_cpu=="arm".  For example, NaCl toolchains
for all different current_cpu values might be instantiated in a build where
target_cpu ist something else.

BUG=592660
BUG=599896
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
R=dpranke@chromium.org
==========

[commit-bot: I haz the power, 2016-04-01 22:09:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-01 22:11:40]

Description was changed from

==========
GN: Declare ARM build arguments for either target_cpu or current_cpu == "arm"

The change in crrev.com/d2eec2ae67e1494bb3a9aa7e0f1c1612298cccc0 fixed
crbug.com/592660 but caused crbug.com/599896.  The ARM build arguments are
relevant both in a build where target_cpu=="arm" and, in other builds, in
toolchain contexts where current_cpu=="arm".  For example, NaCl toolchains
for all different current_cpu values might be instantiated in a build where
target_cpu ist something else.

BUG=592660
BUG=599896
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
R=dpranke@chromium.org
==========

to

==========
GN: Declare ARM build arguments for either target_cpu or current_cpu == "arm"

The change in crrev.com/d2eec2ae67e1494bb3a9aa7e0f1c1612298cccc0 fixed
crbug.com/592660 but caused crbug.com/599896.  The ARM build arguments are
relevant both in a build where target_cpu=="arm" and, in other builds, in
toolchain contexts where current_cpu=="arm".  For example, NaCl toolchains
for all different current_cpu values might be instantiated in a build where
target_cpu ist something else.

BUG=592660
BUG=599896
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
R=dpranke@chromium.org

Committed: https://crrev.com/9ad45bcd53fd0fe40c962ebff8dd7bc3b2d289c9
Cr-Commit-Position: refs/heads/master@{#384703}
==========

[commit-bot: I haz the power, 2016-04-01 22:11:41]

Patchset 1 (id:??) landed as
https://crrev.com/9ad45bcd53fd0fe40c962ebff8dd7bc3b2d289c9
Cr-Commit-Position: refs/heads/master@{#384703}