Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Unified Diff: build/config/arm.gni

Issue 1847063006: GN: Declare ARM build arguments for either target_cpu or current_cpu == "arm" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/arm.gni
diff --git a/build/config/arm.gni b/build/config/arm.gni
index 996694aab32bd328820ce780459dcebf277213ec..c83cf48518b0c4db8bcf0f727568fabd34972e6a 100644
--- a/build/config/arm.gni
+++ b/build/config/arm.gni
@@ -2,7 +2,12 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-if (target_cpu == "arm") {
+# These are primarily relevant in current_cpu == "arm" contexts, where
+# ARM code is being compiled. But they can also be relevant in the
+# host toolchain context when target_cpu == "arm", where a host-side
+# build tool being built will change its behavior depending on the
+# details of the target configuration.
+if (target_cpu == "arm" || current_cpu == "arm") {
declare_args() {
# Version of the ARM processor when compiling on ARM. Ignored on non-ARM
# platforms.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698