src/ic/arm/stub-cache-arm.cc - Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/arm/stub-cache-arm.cc

Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/arm/stub-cache-arm.cc

diff --git a/src/ic/arm/stub-cache-arm.cc b/src/ic/arm/stub-cache-arm.cc

index 86710eb29a8f83240fe5292f2d0ed384a18b7887..8f8ee8e8a7396704640832c65e29f172a4a73ddc 100644

--- a/src/ic/arm/stub-cache-arm.cc

+++ b/src/ic/arm/stub-cache-arm.cc

@@ -103,9 +103,6 @@ void StubCache::GenerateProbe(MacroAssembler* masm, Code::Kind ic_kind,

// entry size being 12.

DCHECK(sizeof(Entry) == 12);

- // Make sure the flags does not name a specific type.

- DCHECK(Code::ExtractTypeFromFlags(flags) == 0);

// Make sure that there are no register conflicts.

DCHECK(!AreAliased(receiver, name, scratch, extra, extra2, extra3));

« no previous file with comments | « src/ic/arm/ic-arm.cc ('k') | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »