Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: src/ic/arm/stub-cache-arm.cc

Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm/ic-arm.cc ('k') | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/stub-cache.h" 9 #include "src/ic/stub-cache.h"
10 #include "src/interface-descriptors.h" 10 #include "src/interface-descriptors.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 Code::Flags flags, Register receiver, 96 Code::Flags flags, Register receiver,
97 Register name, Register scratch, Register extra, 97 Register name, Register scratch, Register extra,
98 Register extra2, Register extra3) { 98 Register extra2, Register extra3) {
99 Isolate* isolate = masm->isolate(); 99 Isolate* isolate = masm->isolate();
100 Label miss; 100 Label miss;
101 101
102 // Make sure that code is valid. The multiplying code relies on the 102 // Make sure that code is valid. The multiplying code relies on the
103 // entry size being 12. 103 // entry size being 12.
104 DCHECK(sizeof(Entry) == 12); 104 DCHECK(sizeof(Entry) == 12);
105 105
106 // Make sure the flags does not name a specific type.
107 DCHECK(Code::ExtractTypeFromFlags(flags) == 0);
108
109 // Make sure that there are no register conflicts. 106 // Make sure that there are no register conflicts.
110 DCHECK(!AreAliased(receiver, name, scratch, extra, extra2, extra3)); 107 DCHECK(!AreAliased(receiver, name, scratch, extra, extra2, extra3));
111 108
112 // Check scratch, extra and extra2 registers are valid. 109 // Check scratch, extra and extra2 registers are valid.
113 DCHECK(!scratch.is(no_reg)); 110 DCHECK(!scratch.is(no_reg));
114 DCHECK(!extra.is(no_reg)); 111 DCHECK(!extra.is(no_reg));
115 DCHECK(!extra2.is(no_reg)); 112 DCHECK(!extra2.is(no_reg));
116 DCHECK(!extra3.is(no_reg)); 113 DCHECK(!extra3.is(no_reg));
117 114
118 #ifdef DEBUG 115 #ifdef DEBUG
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2, 170 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2,
174 extra3); 171 extra3);
175 } 172 }
176 173
177 174
178 #undef __ 175 #undef __
179 } // namespace internal 176 } // namespace internal
180 } // namespace v8 177 } // namespace v8
181 178
182 #endif // V8_TARGET_ARCH_ARM 179 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ic/arm/ic-arm.cc ('k') | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698