Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1846913005: Newline characters in pasted text are not counted correctly for textarea[maxlength]. (Closed)

Created:
4 years, 8 months ago by tkent
Modified:
4 years, 8 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Newline characters in pasted text are not counted correctly for textarea[maxlength]. HTMLTextAreaElement::sanitizeUserInputValue didn't take care of LF->CRLF conversion. BUG=592448 Committed: https://crrev.com/ddcf7881eed02133eac48444d0dec01eeae86438 Cr-Commit-Position: refs/heads/master@{#384508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -3 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +14 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/core/html/HTMLTextAreaElementTest.cpp View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tkent
Keishi, would you review this please?
4 years, 8 months ago (2016-04-01 03:52:35 UTC) #2
keishi
LGTM
4 years, 8 months ago (2016-04-01 04:12:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846913005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846913005/1
4 years, 8 months ago (2016-04-01 06:04:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 07:12:08 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 07:13:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddcf7881eed02133eac48444d0dec01eeae86438
Cr-Commit-Position: refs/heads/master@{#384508}

Powered by Google App Engine
This is Rietveld 408576698