third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp - Issue 1846913005: Newline characters in pasted text are not counted correctly for textarea[maxlength].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

Issue 1846913005: Newline characters in pasted text are not counted correctly for textarea[maxlength]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextAreaElement.h ('k') | third_party/WebKit/Source/core/html/HTMLTextAreaElementTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

index e63808a4969a7b87e5b3dffcd524a7bcd74cb72b..efe165004d7bc56f60c321e4eac377dff135b813 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp

@@ -333,9 +333,20 @@ void HTMLTextAreaElement::handleBeforeTextInsertedEvent(BeforeTextInsertedEvent*

String HTMLTextAreaElement::sanitizeUserInputValue(const String& proposedValue, unsigned maxLength)

{

- if (maxLength > 0 && U16_IS_LEAD(proposedValue[maxLength - 1]))

- --maxLength;

- return proposedValue.left(maxLength);

+ unsigned submissionLength = 0;

+ unsigned i = 0;

+ for (; i < proposedValue.length(); ++i) {

+ submissionLength += proposedValue[i] == '\n' ? 2 : 1;

+ if (submissionLength == maxLength) {

+ ++i;

+ break;

+ }

+ if (submissionLength > maxLength)

+ break;

+ }

+ if (i > 0 && U16_IS_LEAD(proposedValue[i - 1]))

+ --i;

+ return proposedValue.left(i);

}

void HTMLTextAreaElement::updateValue() const