Make wide strings use StringData template

Make wide strings use StringData template

Shuffled the order of methods in fx_basic_wstring.cpp to
match those in fx_basic_bstring.cpp.  The way to review 
this patch is to diff those two files against each other.
They are beginning to converge.

Re-ordered some parameters in Concat() so that the string
comes before its length.  It feels wrong otherwise.

Committed: https://pdfium.googlesource.com/pdfium/+/46bf0331229a7b7fe73cbe111550f5dd467b184a

[Tom Sepez, 2016-04-05 22:35:40]

Description was changed from

==========
Make wide strings use StringData template [wip]
==========

to

==========
Make wide strings use StringData template

Shuffled the order of methods in fx_basic_wstring.cpp to
match those in fx_basic_bstring.cpp.  The way to review 
this patch is to diff those two files against each other.
They are beginning to converge.
==========

[Tom Sepez, 2016-04-05 22:36:27]

Description was changed from

==========
Make wide strings use StringData template

Shuffled the order of methods in fx_basic_wstring.cpp to
match those in fx_basic_bstring.cpp.  The way to review 
this patch is to diff those two files against each other.
They are beginning to converge.
==========

to

==========
Make wide strings use StringData template

Shuffled the order of methods in fx_basic_wstring.cpp to
match those in fx_basic_bstring.cpp.  The way to review 
this patch is to diff those two files against each other.
They are beginning to converge.

Re-ordered some paramters in Concat() so that the string
comes before its length.  It feels wrong otherwise.
==========

[Tom Sepez, 2016-04-06 17:39:17]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-06 17:39:17]

Lei, for review.  You'll want to pull the patch and compare wide vs byte code.

[Lei Zhang, 2016-04-06 19:40:28]

Description was changed from

==========
Make wide strings use StringData template

Shuffled the order of methods in fx_basic_wstring.cpp to
match those in fx_basic_bstring.cpp.  The way to review 
this patch is to diff those two files against each other.
They are beginning to converge.

Re-ordered some paramters in Concat() so that the string
comes before its length.  It feels wrong otherwise.
==========

to

==========
Make wide strings use StringData template

Shuffled the order of methods in fx_basic_wstring.cpp to
match those in fx_basic_bstring.cpp.  The way to review 
this patch is to diff those two files against each other.
They are beginning to converge.

Re-ordered some parameters in Concat() so that the string
comes before its length.  It feels wrong otherwise.
==========

[Tom Sepez, 2016-04-06 21:07:18]

On 2016/04/06 17:39:17, Tom Sepez wrote:
> Lei, for review.  You'll want to pull the patch and compare wide vs byte code.

If that's too hard, let me know and I'll make a move-only change followed by a
code change.

[Lei Zhang, 2016-04-06 23:15:19]

lgtm

https://codereview.chromium.org/1846793002/diff/80001/core/fxcrt/fx_basic_wst...
File core/fxcrt/fx_basic_wstring.cpp (right):

https://codereview.chromium.org/1846793002/diff/80001/core/fxcrt/fx_basic_wst...
core/fxcrt/fx_basic_wstring.cpp:36: const FX_WCHAR* FX_wcsstr(const FX_WCHAR*
str1,
I shrugged at FX_strstr() since it was just a move, but this is "new" code, so
can you rename str1/str2 to haystack/needle?

[Tom Sepez, 2016-04-06 23:23:26]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-04-06 23:23:27]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1846793002/#ps100001
(title: "needle/haystack.")

[commit-bot: I haz the power, 2016-04-06 23:23:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846793002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846793002/100001

[Tom Sepez, 2016-04-06 23:23:30]

https://codereview.chromium.org/1846793002/diff/80001/core/fxcrt/fx_basic_wst...
File core/fxcrt/fx_basic_wstring.cpp (right):

https://codereview.chromium.org/1846793002/diff/80001/core/fxcrt/fx_basic_wst...
core/fxcrt/fx_basic_wstring.cpp:36: const FX_WCHAR* FX_wcsstr(const FX_WCHAR*
str1,
On 2016/04/06 23:15:19, Lei Zhang wrote:
> I shrugged at FX_strstr() since it was just a move, but this is "new" code, so
> can you rename str1/str2 to haystack/needle?

Done in both places.

[Tom Sepez, 2016-04-06 23:47:49]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-04-06 23:47:49]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1846793002/#ps120001
(title: "Fix mac compile")

[commit-bot: I haz the power, 2016-04-06 23:47:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846793002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846793002/120001

[commit-bot: I haz the power, 2016-04-06 23:48:29]

Description was changed from

==========
Make wide strings use StringData template

Shuffled the order of methods in fx_basic_wstring.cpp to
match those in fx_basic_bstring.cpp.  The way to review 
this patch is to diff those two files against each other.
They are beginning to converge.

Re-ordered some parameters in Concat() so that the string
comes before its length.  It feels wrong otherwise.
==========

to

==========
Make wide strings use StringData template

Shuffled the order of methods in fx_basic_wstring.cpp to
match those in fx_basic_bstring.cpp.  The way to review 
this patch is to diff those two files against each other.
They are beginning to converge.

Re-ordered some parameters in Concat() so that the string
comes before its length.  It feels wrong otherwise.

Committed:
https://pdfium.googlesource.com/pdfium/+/46bf0331229a7b7fe73cbe111550f5dd467b...
==========

[commit-bot: I haz the power, 2016-04-06 23:48:30]

Committed patchset #7 (id:120001) as
https://pdfium.googlesource.com/pdfium/+/46bf0331229a7b7fe73cbe111550f5dd467b...