Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1975)

Unified Diff: core/fxcrt/fx_basic_wstring_unittest.cpp

Issue 1846793002: Make wide strings use StringData template (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@template_str
Patch Set: Fix mac compile Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fxcrt/fx_basic_wstring.cpp ('k') | core/fxcrt/include/fx_string.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxcrt/fx_basic_wstring_unittest.cpp
diff --git a/core/fxcrt/fx_basic_wstring_unittest.cpp b/core/fxcrt/fx_basic_wstring_unittest.cpp
index 8f0084619d4b8775860ffea8258b70aa8fc58921..cfc190f72ae75384f98d5dc0f43b8af8c3657622 100644
--- a/core/fxcrt/fx_basic_wstring_unittest.cpp
+++ b/core/fxcrt/fx_basic_wstring_unittest.cpp
@@ -251,26 +251,26 @@ TEST(fxcrt, WideStringOperatorNE) {
TEST(fxcrt, WideStringConcatInPlace) {
CFX_WideString fred;
- fred.ConcatInPlace(4, L"FRED");
+ fred.Concat(L"FRED", 4);
EXPECT_EQ(L"FRED", fred);
- fred.ConcatInPlace(2, L"DY");
+ fred.Concat(L"DY", 2);
EXPECT_EQ(L"FREDDY", fred);
fred.Delete(3, 3);
EXPECT_EQ(L"FRE", fred);
- fred.ConcatInPlace(1, L"D");
+ fred.Concat(L"D", 1);
EXPECT_EQ(L"FRED", fred);
CFX_WideString copy = fred;
- fred.ConcatInPlace(2, L"DY");
+ fred.Concat(L"DY", 2);
EXPECT_EQ(L"FREDDY", fred);
EXPECT_EQ(L"FRED", copy);
// Test invalid arguments.
copy = fred;
- fred.ConcatInPlace(-6, L"freddy");
+ fred.Concat(L"freddy", -6);
CFX_WideString not_aliased(L"xxxxxx");
EXPECT_EQ(L"FREDDY", fred);
EXPECT_EQ(L"xxxxxx", not_aliased);
« no previous file with comments | « core/fxcrt/fx_basic_wstring.cpp ('k') | core/fxcrt/include/fx_string.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698