Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1846733004: Rename IgnoringCacheData to ValidatingCacheData (Closed)

Created:
4 years, 8 months ago by Takashi Toyoshima
Modified:
4 years, 8 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, caseq+blink_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jam, Nate Chapin, kinuko+watch, kozyatinskiy+blink_chromium.org, loading-reviews_chromium.org, loading-reviews+fetch_chromium.org, lushnikov+blink_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename IgnoringCacheData to ValidatingCacheData 'ignoring' is very confusing in current Chromium/Blink repository. 'ignoreCache' is used to specify the strong reload in some areas, but strong reload actually uses BYPASS_CACHE flag, and weak realod uses IGNORE_CACHE. This series of changes remove 'ignore' or 'ignoring' from the code base completely, and use 'validate' and 'bypass' to be consistent with net flags. Also, I drop 'Reload' prefix because this does not represent the flag behavior, but just one of use case to use the flag today. BUG=599364 Committed: https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad Cr-Commit-Position: refs/heads/master@{#384500}

Patch Set 1 #

Patch Set 2 : fix webkit_unit_tests build #

Patch Set 3 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -39 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/web_url_request_util.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/image_downloader/image_downloader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/CachePolicy.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceRequest.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLRequest.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Takashi Toyoshima
Can you review this? This was proposed in chromium-dev and blink-dev, and there are no ...
4 years, 8 months ago (2016-03-31 09:36:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846733004/1
4 years, 8 months ago (2016-03-31 09:41:17 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/87816)
4 years, 8 months ago (2016-03-31 10:02:34 UTC) #6
Takashi Toyoshima
oops, let me fix tests first.
4 years, 8 months ago (2016-03-31 10:23:51 UTC) #7
Takashi Toyoshima
I fixed the webkit_unit_tests build. So can you take a look?
4 years, 8 months ago (2016-03-31 11:29:06 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-03-31 15:28:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846733004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846733004/40001
4 years, 8 months ago (2016-04-01 04:28:21 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-01 06:00:54 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 06:02:46 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad
Cr-Commit-Position: refs/heads/master@{#384500}

Powered by Google App Engine
This is Rietveld 408576698