Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 1846733004: Rename IgnoringCacheData to ValidatingCacheData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl format Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 54669246d58f7910665af82e079fd3f5b8ab7ea9..dc890c103e52157d3e250f1c05979766a0a2a7be 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -5886,7 +5886,7 @@ TEST_P(ParameterizedWebFrameTest, BackToReload)
EXPECT_EQ(firstItem.get(), mainFrameLoader.currentItem());
FrameTestHelpers::reloadFrame(frame);
- EXPECT_EQ(WebURLRequest::ReloadIgnoringCacheData, frame->dataSource()->request().getCachePolicy());
+ EXPECT_EQ(WebURLRequest::ValidatingCacheData, frame->dataSource()->request().getCachePolicy());
}
TEST_P(ParameterizedWebFrameTest, BackDuringChildFrameReload)
@@ -5929,7 +5929,7 @@ TEST_P(ParameterizedWebFrameTest, ReloadPost)
EXPECT_EQ(WebString::fromUTF8("POST"), frame->dataSource()->request().httpMethod());
FrameTestHelpers::reloadFrame(frame);
- EXPECT_EQ(WebURLRequest::ReloadIgnoringCacheData, frame->dataSource()->request().getCachePolicy());
+ EXPECT_EQ(WebURLRequest::ValidatingCacheData, frame->dataSource()->request().getCachePolicy());
EXPECT_EQ(WebNavigationTypeFormResubmitted, frame->dataSource()->navigationType());
}
@@ -5948,9 +5948,9 @@ TEST_P(ParameterizedWebFrameTest, LoadHistoryItemReload)
EXPECT_NE(firstItem.get(), mainFrameLoader.currentItem());
// Cache policy overrides should take.
- FrameTestHelpers::loadHistoryItem(frame, WebHistoryItem(firstItem), WebHistoryDifferentDocumentLoad, WebURLRequest::ReloadIgnoringCacheData);
+ FrameTestHelpers::loadHistoryItem(frame, WebHistoryItem(firstItem), WebHistoryDifferentDocumentLoad, WebURLRequest::ValidatingCacheData);
EXPECT_EQ(firstItem.get(), mainFrameLoader.currentItem());
- EXPECT_EQ(WebURLRequest::ReloadIgnoringCacheData, frame->dataSource()->request().getCachePolicy());
+ EXPECT_EQ(WebURLRequest::ValidatingCacheData, frame->dataSource()->request().getCachePolicy());
}
@@ -6038,7 +6038,7 @@ TEST_P(ParameterizedWebFrameTest, ReloadIframe)
EXPECT_EQ(mainClient.childFrameCreationCount(), 2);
EXPECT_EQ(childClient.willSendRequestCallCount(), 2);
- EXPECT_EQ(childClient.getCachePolicy(), WebURLRequest::ReloadIgnoringCacheData);
+ EXPECT_EQ(childClient.getCachePolicy(), WebURLRequest::ValidatingCacheData);
}
class TestSameDocumentWebFrameClient : public FrameTestHelpers::TestWebFrameClient {
@@ -6879,7 +6879,7 @@ TEST_P(ParameterizedWebFrameTest, ReloadBypassingCache)
webViewHelper.initializeAndLoad(m_baseURL + "foo.html", true);
WebFrame* frame = webViewHelper.webView()->mainFrame();
FrameTestHelpers::reloadFrameIgnoringCache(frame);
- EXPECT_EQ(WebURLRequest::ReloadBypassingCache, frame->dataSource()->request().getCachePolicy());
+ EXPECT_EQ(WebURLRequest::BypassingCache, frame->dataSource()->request().getCachePolicy());
}
static void nodeImageTestValidation(const IntSize& referenceBitmapSize, DragImage* dragImage)
« no previous file with comments | « third_party/WebKit/Source/platform/network/ResourceRequest.h ('k') | third_party/WebKit/public/platform/WebURLRequest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698