Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3528)

Unified Diff: base/build_time_unittest.cc

Issue 1846713002: Improve the error message in BuildTime.InThePast to help figure out the problem. (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Improved comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/build_time.cc ('k') | build/write_build_date_header.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/build_time_unittest.cc
diff --git a/base/build_time_unittest.cc b/base/build_time_unittest.cc
index 30d541aed1c8db7b293e8e8f3546b69a3d376f6d..3a35736356b1157a6c5d6e50b986013a0cdf9a91 100644
--- a/base/build_time_unittest.cc
+++ b/base/build_time_unittest.cc
@@ -11,20 +11,27 @@
TEST(BuildTime, DateLooksValid) {
char build_date[] = BUILD_DATE;
- EXPECT_EQ(11u, strlen(build_date));
+ EXPECT_EQ(20u, strlen(build_date));
EXPECT_EQ(' ', build_date[3]);
EXPECT_EQ(' ', build_date[6]);
+ EXPECT_EQ(' ', build_date[11]);
+ EXPECT_EQ('0', build_date[12]);
+ EXPECT_EQ('5', build_date[13]);
+ EXPECT_EQ(':', build_date[14]);
+ EXPECT_EQ('0', build_date[15]);
+ EXPECT_EQ('0', build_date[16]);
+ EXPECT_EQ(':', build_date[17]);
+ EXPECT_EQ('0', build_date[18]);
+ EXPECT_EQ('0', build_date[19]);
}
-TEST(BuildTime, TimeLooksValid) {
- char build_time[] = "00:00:00";
-
- EXPECT_EQ(8u, strlen(build_time));
- EXPECT_EQ(':', build_time[2]);
- EXPECT_EQ(':', build_time[5]);
+TEST(BuildTime, InThePast) {
+ EXPECT_LT(base::GetBuildTime(), base::Time::Now());
+ EXPECT_LT(base::GetBuildTime(), base::Time::NowFromSystemTime());
}
-TEST(BuildTime, InThePast) {
- EXPECT_TRUE(base::GetBuildTime() < base::Time::Now());
- EXPECT_TRUE(base::GetBuildTime() < base::Time::NowFromSystemTime());
+TEST(BuildTime, NotTooFar) {
+ // BuildTime must be less than 45 days old.
+ base::Time cutoff(base::Time::Now() - base::TimeDelta::FromDays(45));
+ EXPECT_GT(base::GetBuildTime(), cutoff);
}
« no previous file with comments | « base/build_time.cc ('k') | build/write_build_date_header.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698