Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Unified Diff: base/build_time.cc

Issue 1846713002: Improve the error message in BuildTime.InThePast to help figure out the problem. (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Improved comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/BUILD.gn ('k') | base/build_time_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/build_time.cc
diff --git a/base/build_time.cc b/base/build_time.cc
index 6f496f2efd2a9c482151911d8ecad02873935ce3..834b04120185909a489226551e3cea916b53fd28 100644
--- a/base/build_time.cc
+++ b/base/build_time.cc
@@ -14,9 +14,10 @@ namespace base {
Time GetBuildTime() {
Time integral_build_time;
- // BUILD_DATE is exactly "Mmm DD YYYY".
- const char kDateTime[] = BUILD_DATE " 05:00:00";
- bool result = Time::FromUTCString(kDateTime, &integral_build_time);
+ // BUILD_DATE is exactly "Mmm DD YYYY HH:MM:SS".
+ // See //build/write_build_date_header.py. "HH:MM:SS" is normally expected to
+ // be "05:00:00" but is not enforced here.
+ bool result = Time::FromUTCString(BUILD_DATE, &integral_build_time);
DCHECK(result);
return integral_build_time;
}
« no previous file with comments | « base/BUILD.gn ('k') | base/build_time_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698