Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1846683004: App list: Fixed folder reparenting calculation. (Closed)

Created:
4 years, 8 months ago by Matt Giuca
Modified:
4 years, 8 months ago
Reviewers:
calamity
CC:
chromium-reviews, tfarina, Matt Giuca, tapted, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@tapted-applist-deprecation-mac
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

App list: Fixed folder reparenting calculation. Doesn't have any visible effect but it fixes an assumption that will soon not be true (that the root grid view and folder view are at the same location). BUG=599328 Committed: https://crrev.com/5319c96ce234793b9ae72a914ef5bb2e12ca8ca1 Cr-Commit-Position: refs/heads/master@{#384198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/app_list/views/app_list_folder_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
Matt Giuca
4 years, 8 months ago (2016-03-31 03:12:08 UTC) #2
calamity
lgtm
4 years, 8 months ago (2016-03-31 03:14:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846683004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846683004/1
4 years, 8 months ago (2016-03-31 03:17:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846683004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846683004/1
4 years, 8 months ago (2016-03-31 05:02:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 06:06:49 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 06:07:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5319c96ce234793b9ae72a914ef5bb2e12ca8ca1
Cr-Commit-Position: refs/heads/master@{#384198}

Powered by Google App Engine
This is Rietveld 408576698