android webview: Keep zoom methods synchronous

android webview: Keep zoom methods synchronous

Zoom methods became asynchronous after r380563 since zoom
is implemented by generating synthetic pinch zoom gestures.
There is evidence now that some apps depend on synchronous
zoom methods, so this brings back synchronous behavior for
the zoom methods only.

Add a synchronous UpdateState IPC, and send it only after
sending down synthetic zoom events. Note real user input is
still asynchronous.

Re-enable the synchronous zoom test, but had to slightly
relax a check due to rounding error.

BUG=545628
Committed: https://crrev.com/ea69bdb503198d324b112319899ecc5d8d70bfbf
Cr-Commit-Position: refs/heads/master@{#384667}

[boliu, 2016-03-31 01:57:21]

Description was changed from

==========
android webview: Keep zoom methods synchronous

There is evidence that this is a compatibility problem. So fix this and
enable the test. Fix is simple, just send the synchronous UpdateState
message after a zoom call.

BUG=545628
==========

to

==========
android webview: Keep zoom methods synchronous

Zoom methods became asynchronous after r380563 since zoom
is implemented by generating synthetic pinch zoom gestures.
There is evidence now that some apps depend on synchronous
zoom methods, so this brings back synchronous behavior for
the zoom methods only.

Add a synchronous UpdateState IPC, and send it only after
sending down synthetic zoom events. Note real user input is
still asynchronous.

Re-enable the synchronous zoom test, but had to slightly relax
a check due to rounding error.

BUG=545628
==========

[boliu, 2016-03-31 01:57:33]

Description was changed from

==========
android webview: Keep zoom methods synchronous

Zoom methods became asynchronous after r380563 since zoom
is implemented by generating synthetic pinch zoom gestures.
There is evidence now that some apps depend on synchronous
zoom methods, so this brings back synchronous behavior for
the zoom methods only.

Add a synchronous UpdateState IPC, and send it only after
sending down synthetic zoom events. Note real user input is
still asynchronous.

Re-enable the synchronous zoom test, but had to slightly relax
a check due to rounding error.

BUG=545628
==========

to

==========
android webview: Keep zoom methods synchronous

Zoom methods became asynchronous after r380563 since zoom
is implemented by generating synthetic pinch zoom gestures.
There is evidence now that some apps depend on synchronous
zoom methods, so this brings back synchronous behavior for
the zoom methods only.

Add a synchronous UpdateState IPC, and send it only after
sending down synthetic zoom events. Note real user input is
still asynchronous.

Re-enable the synchronous zoom test, but had to slightly
relax a check due to rounding error.

BUG=545628
==========

[boliu, 2016-03-31 02:48:52]

boliu@chromium.org changed reviewers:
+ dcheng@chromium.org, sievers@chromium.org

[boliu, 2016-03-31 02:48:52]

PTAL

dcheng for sync_compositor_messages.h
sievers for everything else

[dcheng, 2016-03-31 19:51:56]

ipc changes lgtm

https://codereview.chromium.org/1846653003/diff/40001/content/common/android/...
File content/common/android/sync_compositor_messages.h (right):

https://codereview.chromium.org/1846653003/diff/40001/content/common/android/...
content/common/android/sync_compositor_messages.h:183:
IPC_SYNC_MESSAGE_ROUTED1_1(SyncCompositorMsg_SynchronousUpdateState,
I think we need a link to a design doc or overview somewhere. I recall being
convinced that sync IPC from the browser to the renderer for compositor was OK
but I don't recall why without doing a bunch of research again.

[dcheng, 2016-03-31 19:52:23]

https://codereview.chromium.org/1846653003/diff/40001/content/common/android/...
File content/common/android/sync_compositor_messages.h (right):

https://codereview.chromium.org/1846653003/diff/40001/content/common/android/...
content/common/android/sync_compositor_messages.h:183:
IPC_SYNC_MESSAGE_ROUTED1_1(SyncCompositorMsg_SynchronousUpdateState,
On 2016/03/31 at 19:51:56, dcheng wrote:
> I think we need a link to a design doc or overview somewhere. I recall being
convinced that sync IPC from the browser to the renderer for compositor was OK
but I don't recall why without doing a bunch of research again.

Also, maybe some comments describing why we need both UpdateState and
SynchronousUpdateState would be good.

[boliu, 2016-03-31 20:16:34]

https://codereview.chromium.org/1846653003/diff/40001/content/common/android/...
File content/common/android/sync_compositor_messages.h (right):

https://codereview.chromium.org/1846653003/diff/40001/content/common/android/...
content/common/android/sync_compositor_messages.h:183:
IPC_SYNC_MESSAGE_ROUTED1_1(SyncCompositorMsg_SynchronousUpdateState,
On 2016/03/31 19:52:22, dcheng wrote:
> On 2016/03/31 at 19:51:56, dcheng wrote:
> > I think we need a link to a design doc or overview somewhere. I recall being
> convinced that sync IPC from the browser to the renderer for compositor was OK
> but I don't recall why without doing a bunch of research again.
> 
> Also, maybe some comments describing why we need both UpdateState and
> SynchronousUpdateState would be good.

Good call on both counts.

Added link to bug and design doc above on Line 141. And added a comment here
that SynchronousUpdateState should be needed rarely needed, and should used the
async version in general.

[no sievers, 2016-04-01 18:56:10]

lgtm

[boliu, 2016-04-01 18:56:54]

The CQ bit was checked by boliu@chromium.org

[boliu, 2016-04-01 18:56:55]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1846653003/#ps60001
(title: "ipc comments")

[commit-bot: I haz the power, 2016-04-01 18:57:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846653003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846653003/60001

[commit-bot: I haz the power, 2016-04-01 19:58:24]

Description was changed from

==========
android webview: Keep zoom methods synchronous

Zoom methods became asynchronous after r380563 since zoom
is implemented by generating synthetic pinch zoom gestures.
There is evidence now that some apps depend on synchronous
zoom methods, so this brings back synchronous behavior for
the zoom methods only.

Add a synchronous UpdateState IPC, and send it only after
sending down synthetic zoom events. Note real user input is
still asynchronous.

Re-enable the synchronous zoom test, but had to slightly
relax a check due to rounding error.

BUG=545628
==========

to

==========
android webview: Keep zoom methods synchronous

Zoom methods became asynchronous after r380563 since zoom
is implemented by generating synthetic pinch zoom gestures.
There is evidence now that some apps depend on synchronous
zoom methods, so this brings back synchronous behavior for
the zoom methods only.

Add a synchronous UpdateState IPC, and send it only after
sending down synthetic zoom events. Note real user input is
still asynchronous.

Re-enable the synchronous zoom test, but had to slightly
relax a check due to rounding error.

BUG=545628
==========

[commit-bot: I haz the power, 2016-04-01 19:58:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-01 20:00:00]

Description was changed from

==========
android webview: Keep zoom methods synchronous

Zoom methods became asynchronous after r380563 since zoom
is implemented by generating synthetic pinch zoom gestures.
There is evidence now that some apps depend on synchronous
zoom methods, so this brings back synchronous behavior for
the zoom methods only.

Add a synchronous UpdateState IPC, and send it only after
sending down synthetic zoom events. Note real user input is
still asynchronous.

Re-enable the synchronous zoom test, but had to slightly
relax a check due to rounding error.

BUG=545628
==========

to

==========
android webview: Keep zoom methods synchronous

Zoom methods became asynchronous after r380563 since zoom
is implemented by generating synthetic pinch zoom gestures.
There is evidence now that some apps depend on synchronous
zoom methods, so this brings back synchronous behavior for
the zoom methods only.

Add a synchronous UpdateState IPC, and send it only after
sending down synthetic zoom events. Note real user input is
still asynchronous.

Re-enable the synchronous zoom test, but had to slightly
relax a check due to rounding error.

BUG=545628

Committed: https://crrev.com/ea69bdb503198d324b112319899ecc5d8d70bfbf
Cr-Commit-Position: refs/heads/master@{#384667}
==========

[commit-bot: I haz the power, 2016-04-01 20:00:01]

Patchset 4 (id:??) landed as
https://crrev.com/ea69bdb503198d324b112319899ecc5d8d70bfbf
Cr-Commit-Position: refs/heads/master@{#384667}