Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: android_webview/browser/browser_view_renderer.cc

Issue 1846653003: android webview: Keep zoom methods synchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ipc comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/browser/browser_view_renderer.h" 5 #include "android_webview/browser/browser_view_renderer.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "android_webview/browser/browser_view_renderer_client.h" 9 #include "android_webview/browser/browser_view_renderer_client.h"
10 #include "android_webview/browser/child_frame.h" 10 #include "android_webview/browser/child_frame.h"
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 void BrowserViewRenderer::OnDetachedFromWindow() { 404 void BrowserViewRenderer::OnDetachedFromWindow() {
405 TRACE_EVENT0("android_webview", "BrowserViewRenderer::OnDetachedFromWindow"); 405 TRACE_EVENT0("android_webview", "BrowserViewRenderer::OnDetachedFromWindow");
406 hardware_enabled_ = false; 406 hardware_enabled_ = false;
407 attached_to_window_ = false; 407 attached_to_window_ = false;
408 ReturnUnusedResource(shared_renderer_state_->PassUncommittedFrameOnUI()); 408 ReturnUnusedResource(shared_renderer_state_->PassUncommittedFrameOnUI());
409 ReturnResourceFromParent(); 409 ReturnResourceFromParent();
410 UpdateMemoryPolicy(); 410 UpdateMemoryPolicy();
411 UpdateCompositorIsActive(); 411 UpdateCompositorIsActive();
412 } 412 }
413 413
414 void BrowserViewRenderer::SynchronizeRendererScroll() {
415 if (!compositor_)
416 return;
417 compositor_->SynchronizeWithRenderer();
418 }
419
414 void BrowserViewRenderer::OnComputeScroll(base::TimeTicks animation_time) { 420 void BrowserViewRenderer::OnComputeScroll(base::TimeTicks animation_time) {
415 if (!compositor_) 421 if (!compositor_)
416 return; 422 return;
417 TRACE_EVENT0("android_webview", "BrowserViewRenderer::OnComputeScroll"); 423 TRACE_EVENT0("android_webview", "BrowserViewRenderer::OnComputeScroll");
418 compositor_->OnComputeScroll(animation_time); 424 compositor_->OnComputeScroll(animation_time);
419 } 425 }
420 426
421 bool BrowserViewRenderer::IsVisible() const { 427 bool BrowserViewRenderer::IsVisible() const {
422 // Ignore |window_visible_| if |attached_to_window_| is false. 428 // Ignore |window_visible_| if |attached_to_window_| is false.
423 return view_visible_ && (!attached_to_window_ || window_visible_); 429 return view_visible_ && (!attached_to_window_ || window_visible_);
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
693 base::StringAppendF(&str, 699 base::StringAppendF(&str,
694 "overscroll_rounding_error_: %s ", 700 "overscroll_rounding_error_: %s ",
695 overscroll_rounding_error_.ToString().c_str()); 701 overscroll_rounding_error_.ToString().c_str());
696 base::StringAppendF( 702 base::StringAppendF(
697 &str, "on_new_picture_enable: %d ", on_new_picture_enable_); 703 &str, "on_new_picture_enable: %d ", on_new_picture_enable_);
698 base::StringAppendF(&str, "clear_view: %d ", clear_view_); 704 base::StringAppendF(&str, "clear_view: %d ", clear_view_);
699 return str; 705 return str;
700 } 706 }
701 707
702 } // namespace android_webview 708 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/browser/browser_view_renderer.h ('k') | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698