Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: build/config/BUILD.gn

Issue 1846373002: Revert of Patch to try dump-on-DCHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | third_party/WebKit/Source/wtf/Assertions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/crypto.gni") 8 import("//build/config/crypto.gni")
9 import("//build/config/features.gni") 9 import("//build/config/features.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 # Can be defined without ENABLE_BASIC_PRINTING. 85 # Can be defined without ENABLE_BASIC_PRINTING.
86 defines += [ "ENABLE_PRINT_PREVIEW=1" ] 86 defines += [ "ENABLE_PRINT_PREVIEW=1" ]
87 } 87 }
88 } 88 }
89 if (enable_spellcheck) { 89 if (enable_spellcheck) {
90 defines += [ "ENABLE_SPELLCHECK=1" ] 90 defines += [ "ENABLE_SPELLCHECK=1" ]
91 } 91 }
92 if (use_browser_spellchecker) { 92 if (use_browser_spellchecker) {
93 defines += [ "USE_BROWSER_SPELLCHECKER=1" ] 93 defines += [ "USE_BROWSER_SPELLCHECKER=1" ]
94 } 94 }
95
96 # In Windows official builds, this will cause DCHECKs to
97 # dump-without-crashing. See crbug.com/596231.
98 if (is_official_build && is_win) {
99 dcheck_always_on = true
100 defines += [ "DCHECK_IS_DUMP_WITHOUT_CRASH=1" ]
101 }
102
103 if (dcheck_always_on) { 95 if (dcheck_always_on) {
104 defines += [ "DCHECK_ALWAYS_ON=1" ] 96 defines += [ "DCHECK_ALWAYS_ON=1" ]
105 } 97 }
106 if (use_udev) { 98 if (use_udev) {
107 # TODO(brettw) should probably be "=1". 99 # TODO(brettw) should probably be "=1".
108 defines += [ "USE_UDEV" ] 100 defines += [ "USE_UDEV" ]
109 } 101 }
110 if (ui_compositor_image_transport) { 102 if (ui_compositor_image_transport) {
111 # TODO(brettw) should probably be "=1". 103 # TODO(brettw) should probably be "=1".
112 defines += [ "UI_COMPOSITOR_IMAGE_TRANSPORT" ] 104 defines += [ "UI_COMPOSITOR_IMAGE_TRANSPORT" ]
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
475 # file doesn't exist, no error will be generated (probably MS tested this 467 # file doesn't exist, no error will be generated (probably MS tested this
476 # case but forgot the other one?). To reproduce this error, do a build, 468 # case but forgot the other one?). To reproduce this error, do a build,
477 # then delete the precompile.c.obj file, then build again. 469 # then delete the precompile.c.obj file, then build again.
478 cflags_c = [ "/wd4206" ] 470 cflags_c = [ "/wd4206" ]
479 } else if (is_mac) { 471 } else if (is_mac) {
480 precompiled_header = "build/precompile.h" 472 precompiled_header = "build/precompile.h"
481 precompiled_source = "//build/precompile.h" 473 precompiled_source = "//build/precompile.h"
482 } 474 }
483 } 475 }
484 } 476 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | third_party/WebKit/Source/wtf/Assertions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698