Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: trunk/LayoutTests/fast/loader/resources/subframe-navigate-during-main-frame-load2.html

Issue 184633004: Revert 168553 "id of iframe incorrectly sets window name" (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/LayoutTests/fast/loader/resources/subframe-navigate-during-main-frame-load2.html
===================================================================
--- trunk/LayoutTests/fast/loader/resources/subframe-navigate-during-main-frame-load2.html (revision 168578)
+++ trunk/LayoutTests/fast/loader/resources/subframe-navigate-during-main-frame-load2.html (working copy)
@@ -4,7 +4,7 @@
function runTest()
{
- window.frames["subframe"].location = 'data:text/html,<body onload="testRunner.notifyDone();"></body>';
+ document.getElementById("subframe").contentWindow.location = 'data:text/html,<body onload="testRunner.notifyDone();"></body>';
}
</script>
@@ -13,7 +13,7 @@
<body onload="runTest();">
This test navigates an iframe while it's onload handler is still running.<br>
The iframe navigation should *not* result in a second back-history item being created for the top level navigation.<br>
-<iframe name="subframe" src="about:blank"></iframe><br>
+<iframe id="subframe" src="about:blank"></iframe><br>
</body>

Powered by Google App Engine
This is Rietveld 408576698