trunk/LayoutTests/fast/images/exif-orientation-image-document.html - Issue 184633004: Revert 168553 "id of iframe incorrectly sets window name"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/LayoutTests/fast/images/exif-orientation-image-document.html

Issue 184633004: Revert 168553 "id of iframe incorrectly sets window name" (Closed) Base URL: svn://svn.chromium.org/blink/

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « trunk/LayoutTests/fast/history/saves-state-after-frame-nav.html ('k') | trunk/LayoutTests/fast/loader/resources/subframe-navigate-during-main-frame-load2.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: trunk/LayoutTests/fast/images/exif-orientation-image-document.html

===================================================================

--- trunk/LayoutTests/fast/images/exif-orientation-image-document.html (revision 168578)

+++ trunk/LayoutTests/fast/images/exif-orientation-image-document.html (working copy)

@@ -13,8 +13,8 @@

console.appendChild(li);

}

-function imageSize(name) {

- var img = window.frames[name].document.querySelector('img');

+function imageSize(id) {

+ var img = window.frames[id].document.querySelector('img');

return [img.offsetWidth, img.offsetHeight];

}

@@ -41,17 +41,17 @@

</head>

<b>The images should be rotated respecting their EXIF orientation. In image documents, this happens independent of WebKitShouldRespectImageOrientation.</b><br><br>

-<iframe name="img1" src="resources/exif-orientation-1-ul.jpg" frameborder=0></iframe>

-<iframe name="img2" src="resources/exif-orientation-2-ur.jpg" frameborder=0></iframe>

-<iframe name="img3" src="resources/exif-orientation-3-lr.jpg" frameborder=0></iframe>

-<iframe name="img4" src="resources/exif-orientation-4-lol.jpg" frameborder=0></iframe>

+<iframe id="img1" src="resources/exif-orientation-1-ul.jpg" frameborder=0></iframe>

+<iframe id="img2" src="resources/exif-orientation-2-ur.jpg" frameborder=0></iframe>

+<iframe id="img3" src="resources/exif-orientation-3-lr.jpg" frameborder=0></iframe>

+<iframe id="img4" src="resources/exif-orientation-4-lol.jpg" frameborder=0></iframe>

<br>

-<iframe name="img5" src="resources/exif-orientation-5-lu.jpg" frameborder=0></iframe>

-<iframe name="img6" src="resources/exif-orientation-6-ru.jpg" frameborder=0></iframe>

-<iframe name="img7" src="resources/exif-orientation-7-rl.jpg" frameborder=0></iframe>

-<iframe name="img8" src="resources/exif-orientation-8-llo.jpg" frameborder=0></iframe>

+<iframe id="img5" src="resources/exif-orientation-5-lu.jpg" frameborder=0></iframe>

+<iframe id="img6" src="resources/exif-orientation-6-ru.jpg" frameborder=0></iframe>

+<iframe id="img7" src="resources/exif-orientation-7-rl.jpg" frameborder=0></iframe>

+<iframe id="img8" src="resources/exif-orientation-8-llo.jpg" frameborder=0></iframe>

<br>

-<iframe name="img9" src="resources/exif-orientation-9-u.jpg" frameborder=0></iframe>

+<iframe id="img9" src="resources/exif-orientation-9-u.jpg" frameborder=0></iframe>

<br>

</body>