Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 1846303002: Further ES2015 RegExp spec compliance fixes (Closed)

Created:
4 years, 8 months ago by Dan Ehrenberg
Modified:
4 years, 8 months ago
Reviewers:
adamk, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Further ES2015 RegExp spec compliance fixes - RegExp.prototype.toString() doesn't have any special handling of RegExp instances and simply calls the source and flags getters - Use the original values of global and sticky, rather than based on the current flag getters, as specified in https://github.com/tc39/ecma262/pull/494 R=yangguo@chromium.org,adamk LOG=Y BUG=v8:4602 Committed: https://crrev.com/277f5bd0a3b548534d15a8be2afcd4b34cdd756f Cr-Commit-Position: refs/heads/master@{#35225}

Patch Set 1 #

Patch Set 2 : Fix cctest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -40 lines) Patch
M src/js/regexp.js View 3 chunks +10 lines, -23 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/es6/classes-subclass-builtins.js View 1 chunk +7 lines, -1 line 0 comments Download
M test/mjsunit/es6/regexp-constructor.js View 1 chunk +17 lines, -2 lines 0 comments Download
M test/mjsunit/es6/regexp-flags.js View 1 chunk +4 lines, -3 lines 0 comments Download
M test/mjsunit/es6/regexp-tostring.js View 1 chunk +11 lines, -0 lines 0 comments Download
M test/test262/test262.status View 2 chunks +16 lines, -7 lines 0 comments Download
M test/webkit/fast/regex/toString-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846303002/1
4 years, 8 months ago (2016-04-01 18:38:15 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/12415)
4 years, 8 months ago (2016-04-01 18:49:26 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846303002/20001
4 years, 8 months ago (2016-04-01 18:54:35 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 19:16:58 UTC) #8
Dan Ehrenberg
4 years, 8 months ago (2016-04-01 19:17:57 UTC) #9
Yang
lgtm
4 years, 8 months ago (2016-04-04 06:40:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846303002/20001
4 years, 8 months ago (2016-04-04 06:43:03 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-04 07:05:55 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 07:06:29 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/277f5bd0a3b548534d15a8be2afcd4b34cdd756f
Cr-Commit-Position: refs/heads/master@{#35225}

Powered by Google App Engine
This is Rietveld 408576698