Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Unified Diff: test/mjsunit/es6/classes-subclass-builtins.js

Issue 1846303002: Further ES2015 RegExp spec compliance fixes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix cctest Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-regexp.cc ('k') | test/mjsunit/es6/regexp-constructor.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/es6/classes-subclass-builtins.js
diff --git a/test/mjsunit/es6/classes-subclass-builtins.js b/test/mjsunit/es6/classes-subclass-builtins.js
index e36ba0a90f58aff5d7f16acc895204de89f4df99..7669ef3a8a7e0168cdf48c5ebce8e66cf052b2ab 100644
--- a/test/mjsunit/es6/classes-subclass-builtins.js
+++ b/test/mjsunit/es6/classes-subclass-builtins.js
@@ -919,7 +919,13 @@ function TestMapSetSubclassing(container, is_map) {
var o = Reflect.construct(RegExp, [pattern], f);
assertEquals(["match", "tostring"], log);
- assertEquals(/biep/, o);
+ // TODO(littledan): Is the RegExp constructor correct to create
+ // the internal slots and do these type checks this way?
+ assertEquals("biep", %_RegExpSource(o));
+ assertThrows(() => Object.getOwnPropertyDescriptor(RegExp.prototype,
+ 'source').get(o),
+ TypeError);
+ assertEquals("/undefined/undefined", RegExp.prototype.toString.call(o));
assertTrue(o.__proto__ === p2);
assertTrue(f.prototype === p3);
})();
« no previous file with comments | « test/cctest/test-regexp.cc ('k') | test/mjsunit/es6/regexp-constructor.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698