Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1846193002:
Remove commented out layout tests failures (Closed)
|
Created:
4 years, 8 months ago by radu.velea Modified:
4 years, 8 months ago Reviewers:
robert.bradford CC:
chromium-reviews, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove commented out layout tests failures
After the autorebaseline ran for
https://codereview.chromium.org/1779163002
The following tests now pass on Windows:
fast/images/color-profile-background-clip-text.html and
fast/images/color-profile-svg-fill-text.html
Rather than uncommenting as per TODO. They can simply be removed.
BUG=591901, 580917
NOTRY=true
Committed: https://crrev.com/b93a925584694b4113e359279a3a1a402a1174b9
Cr-Commit-Position: refs/heads/master@{#384560}
Patch Set 1 #Patch Set 2 : Removing tests #Messages
Total messages: 21 (14 generated)
Description was changed from ========== Uncomment tests after landing patch 1779163002 BUG=580917 ========== to ========== Uncomment tests after landing patch 1779163002 NOTRY=True BUG=580917 ==========
The CQ bit was checked by robert.bradford@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846193002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Uncomment tests after landing patch 1779163002 NOTRY=True BUG=580917 ========== to ========== Uncomment tests after landing patch 1779163002 BUG=580917 ==========
The CQ bit was checked by robert.bradford@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846193002/1
Description was changed from ========== Uncomment tests after landing patch 1779163002 BUG=580917 ========== to ========== Uncomment tests after landing patch 1779163002 Test expectations were changed after https://codereview.chromium.org/1779163002 In order not to conflict with existing entries, some tests were commented-out. This CL uncomments those changes. BUG=580917 ==========
Description was changed from ========== Uncomment tests after landing patch 1779163002 Test expectations were changed after https://codereview.chromium.org/1779163002 In order not to conflict with existing entries, some tests were commented-out. This CL uncomments those changes. BUG=580917 ========== to ========== Layout tests no longer fail after 1779163002 https://codereview.chromium.org/1846193002 fixed the 2 failing tests. fast/images/color-profile-background-clip-text.html and fast/images/color-profile-svg-fill-text.html were commented out and this CL removes them altogether from the TestExpectations. BUG=591901 ==========
Description was changed from ========== Layout tests no longer fail after 1779163002 https://codereview.chromium.org/1846193002 fixed the 2 failing tests. fast/images/color-profile-background-clip-text.html and fast/images/color-profile-svg-fill-text.html were commented out and this CL removes them altogether from the TestExpectations. BUG=591901 ========== to ========== Layout tests no longer fail after 1779163002 https://codereview.chromium.org/1846193002 fixed the 2 failing tests. fast/images/color-profile-background-clip-text.html and fast/images/color-profile-svg-fill-text.html were commented out and this CL removes them altogether from the TestExpectations. BUG=591901 ==========
Description was changed from ========== Layout tests no longer fail after 1779163002 https://codereview.chromium.org/1846193002 fixed the 2 failing tests. fast/images/color-profile-background-clip-text.html and fast/images/color-profile-svg-fill-text.html were commented out and this CL removes them altogether from the TestExpectations. BUG=591901 ========== to ========== Remove commented out layout tests failures After the autorebaseline ran for https://codereview.chromium.org/1779163002 The following tests now pass on Windows: fast/images/color-profile-background-clip-text.html and fast/images/color-profile-svg-fill-text.html BUG=591901,580917 ==========
Description was changed from ========== Remove commented out layout tests failures After the autorebaseline ran for https://codereview.chromium.org/1779163002 The following tests now pass on Windows: fast/images/color-profile-background-clip-text.html and fast/images/color-profile-svg-fill-text.html BUG=591901,580917 ========== to ========== Remove commented out layout tests failures After the autorebaseline ran for https://codereview.chromium.org/1779163002 The following tests now pass on Windows: fast/images/color-profile-background-clip-text.html and fast/images/color-profile-svg-fill-text.html BUG=591901,580917 NOTRY=true ==========
Description was changed from ========== Remove commented out layout tests failures After the autorebaseline ran for https://codereview.chromium.org/1779163002 The following tests now pass on Windows: fast/images/color-profile-background-clip-text.html and fast/images/color-profile-svg-fill-text.html BUG=591901,580917 NOTRY=true ========== to ========== Remove commented out layout tests failures After the autorebaseline ran for https://codereview.chromium.org/1779163002 The following tests now pass on Windows: fast/images/color-profile-background-clip-text.html and fast/images/color-profile-svg-fill-text.html Rather than uncommenting as per TODO. They can simply be removed. BUG=591901,580917 NOTRY=true ==========
The CQ bit was checked by robert.bradford@intel.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846193002/20001
Message was sent while issue was closed.
Description was changed from ========== Remove commented out layout tests failures After the autorebaseline ran for https://codereview.chromium.org/1779163002 The following tests now pass on Windows: fast/images/color-profile-background-clip-text.html and fast/images/color-profile-svg-fill-text.html Rather than uncommenting as per TODO. They can simply be removed. BUG=591901,580917 NOTRY=true ========== to ========== Remove commented out layout tests failures After the autorebaseline ran for https://codereview.chromium.org/1779163002 The following tests now pass on Windows: fast/images/color-profile-background-clip-text.html and fast/images/color-profile-svg-fill-text.html Rather than uncommenting as per TODO. They can simply be removed. BUG=591901,580917 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove commented out layout tests failures After the autorebaseline ran for https://codereview.chromium.org/1779163002 The following tests now pass on Windows: fast/images/color-profile-background-clip-text.html and fast/images/color-profile-svg-fill-text.html Rather than uncommenting as per TODO. They can simply be removed. BUG=591901,580917 NOTRY=true ========== to ========== Remove commented out layout tests failures After the autorebaseline ran for https://codereview.chromium.org/1779163002 The following tests now pass on Windows: fast/images/color-profile-background-clip-text.html and fast/images/color-profile-svg-fill-text.html Rather than uncommenting as per TODO. They can simply be removed. BUG=591901,580917 NOTRY=true Committed: https://crrev.com/b93a925584694b4113e359279a3a1a402a1174b9 Cr-Commit-Position: refs/heads/master@{#384560} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b93a925584694b4113e359279a3a1a402a1174b9 Cr-Commit-Position: refs/heads/master@{#384560} |
