Add assertions to FrameSummary and Code::SourcePosition.

Add assertions to FrameSummary and Code::SourcePosition.

Make sure we don't use arbitrary optimized code in FrameSummary.

R=bmeurer@chromium.org

Committed: https://crrev.com/1f895a06bd36666e6b19080dcea2e129947bb205
Cr-Commit-Position: refs/heads/master@{#35191}

[Benedikt Meurer, 2016-04-01 07:50:21]

LGTM with nit.

https://codereview.chromium.org/1846183002/diff/1/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/1846183002/diff/1/src/frames.cc#newcode957
src/frames.cc:957: bool CannotDeoptFromAsmCode(Code* code, JSFunction* function)
{
Nit: Put into anonymous namespace.

[Yang, 2016-04-01 07:58:19]

On 2016/04/01 07:50:21, Benedikt Meurer wrote:
> LGTM with nit.
> 
> https://codereview.chromium.org/1846183002/diff/1/src/frames.cc
> File src/frames.cc (right):
> 
> https://codereview.chromium.org/1846183002/diff/1/src/frames.cc#newcode957
> src/frames.cc:957: bool CannotDeoptFromAsmCode(Code* code, JSFunction*
function)
> {
> Nit: Put into anonymous namespace.

Done. Landing.

[Yang, 2016-04-01 07:58:22]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-04-01 07:58:23]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1846183002/#ps20001
(title: "address comment")

[commit-bot: I haz the power, 2016-04-01 07:58:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846183002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846183002/20001

[commit-bot: I haz the power, 2016-04-01 08:14:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 08:14:25]

Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/16087)

[Yang, 2016-04-01 08:42:27]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-04-01 08:42:28]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1846183002/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2016-04-01 08:42:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846183002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846183002/40001

[commit-bot: I haz the power, 2016-04-01 09:06:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-01 09:07:06]

Description was changed from

==========
Add assertions to FrameSummary and Code::SourcePosition.

Make sure we don't use arbitrary optimized code in FrameSummary.

R=bmeurer@chromium.org
==========

to

==========
Add assertions to FrameSummary and Code::SourcePosition.

Make sure we don't use arbitrary optimized code in FrameSummary.

R=bmeurer@chromium.org

Committed: https://crrev.com/1f895a06bd36666e6b19080dcea2e129947bb205
Cr-Commit-Position: refs/heads/master@{#35191}
==========

[commit-bot: I haz the power, 2016-04-01 09:07:07]

Patchset 3 (id:??) landed as
https://crrev.com/1f895a06bd36666e6b19080dcea2e129947bb205
Cr-Commit-Position: refs/heads/master@{#35191}