src/objects.cc - Issue 1846183002: Add assertions to FrameSummary and Code::SourcePosition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1846183002: Add assertions to FrameSummary and Code::SourcePosition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index a6b3edef56f8953d69dbf16602ad6a03bedee366..b525222d82d3b7033402fc8b6e174b15fc8c942a 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -14057,6 +14057,8 @@ int Code::SourcePosition(int code_offset) {

}

it.next();

}

+ DCHECK(kind() == FUNCTION || is_optimized_code() && is_turbofanned() ||

+ is_wasm_code() || position == RelocInfo::kNoPosition);

return position;

}

« no previous file with comments | « src/frames.cc ('k') | no next file » | no next file with comments »