Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1846133003: Replace NOTREACHED() with NOTIMPLEMENTED() for TCP sockets in ChromiumPacketSocketFactory. (Closed)

Created:
4 years, 8 months ago by Sergey Ulanov
Modified:
4 years, 8 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace NOTREACHED() with NOTIMPLEMENTED() for TCP sockets in ChromiumPacketSocketFactory. Previously chromoting host wasn't using TCP. Now it may use it for WebRTC-based connections. Replaced NOTREACHED() with NOTIMPLEMENTED(), so Debug builds don't crash until TCP support is implemented. BUG=600032 Committed: https://crrev.com/ae912cd1b889cdfdc5cd85d4878e929dc7d6b3e2 Cr-Commit-Position: refs/heads/master@{#384780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M remoting/protocol/chromium_socket_factory.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sergey Ulanov
4 years, 8 months ago (2016-04-02 00:31:54 UTC) #2
Jamie
lgtm
4 years, 8 months ago (2016-04-02 01:08:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846133003/1
4 years, 8 months ago (2016-04-02 01:08:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-02 01:42:33 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 01:43:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae912cd1b889cdfdc5cd85d4878e929dc7d6b3e2
Cr-Commit-Position: refs/heads/master@{#384780}

Powered by Google App Engine
This is Rietveld 408576698