Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: remoting/protocol/chromium_socket_factory.cc

Issue 1846133003: Replace NOTREACHED() with NOTIMPLEMENTED() for TCP sockets in ChromiumPacketSocketFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/protocol/chromium_socket_factory.h" 5 #include "remoting/protocol/chromium_socket_factory.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 if (!result->Init(local_address, min_port, max_port)) 379 if (!result->Init(local_address, min_port, max_port))
380 return nullptr; 380 return nullptr;
381 return result.release(); 381 return result.release();
382 } 382 }
383 383
384 rtc::AsyncPacketSocket* ChromiumPacketSocketFactory::CreateServerTcpSocket( 384 rtc::AsyncPacketSocket* ChromiumPacketSocketFactory::CreateServerTcpSocket(
385 const rtc::SocketAddress& local_address, 385 const rtc::SocketAddress& local_address,
386 uint16_t min_port, 386 uint16_t min_port,
387 uint16_t max_port, 387 uint16_t max_port,
388 int opts) { 388 int opts) {
389 // We don't use TCP sockets for remoting connections. 389 // TCP sockets are not supported.
390 // TODO(sergeyu): Implement TCP support crbug.com/600032 .
390 NOTIMPLEMENTED(); 391 NOTIMPLEMENTED();
391 return nullptr; 392 return nullptr;
392 } 393 }
393 394
394 rtc::AsyncPacketSocket* 395 rtc::AsyncPacketSocket*
395 ChromiumPacketSocketFactory::CreateClientTcpSocket( 396 ChromiumPacketSocketFactory::CreateClientTcpSocket(
396 const rtc::SocketAddress& local_address, 397 const rtc::SocketAddress& local_address,
397 const rtc::SocketAddress& remote_address, 398 const rtc::SocketAddress& remote_address,
398 const rtc::ProxyInfo& proxy_info, 399 const rtc::ProxyInfo& proxy_info,
399 const std::string& user_agent, 400 const std::string& user_agent,
400 int opts) { 401 int opts) {
401 // We don't use TCP sockets for remoting connections. 402 // TCP sockets are not supported.
402 NOTREACHED(); 403 // TODO(sergeyu): Implement TCP support crbug.com/600032 .
404 NOTIMPLEMENTED();
403 return nullptr; 405 return nullptr;
404 } 406 }
405 407
406 rtc::AsyncResolverInterface* 408 rtc::AsyncResolverInterface*
407 ChromiumPacketSocketFactory::CreateAsyncResolver() { 409 ChromiumPacketSocketFactory::CreateAsyncResolver() {
408 return new rtc::AsyncResolver(); 410 return new rtc::AsyncResolver();
409 } 411 }
410 412
411 } // namespace protocol 413 } // namespace protocol
412 } // namespace remoting 414 } // namespace remoting
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698