Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1846073002: Use wildcards for too-long suppressions. (Closed)

Created:
4 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Jamie Madill
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use wildcards for too-long suppressions. Bypassing the unittest, as expected, didn't help. Instead write these two suppressions using wildcards so that they still apply. BUG=599451 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/0d4b3081c987155b6e5ae3d2f9058ddf3af7013f Cr-Commit-Position: refs/heads/master@{#384452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Ken Russell (switch to Gerrit)
PTAL
4 years, 8 months ago (2016-03-31 23:06:47 UTC) #3
Zhenyao Mo
On 2016/03/31 23:06:47, Ken Russell wrote: > PTAL lgtm
4 years, 8 months ago (2016-03-31 23:07:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846073002/1
4 years, 8 months ago (2016-03-31 23:08:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 00:51:31 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0d4b3081c987155b6e5ae3d2f9058ddf3af7013f Cr-Commit-Position: refs/heads/master@{#384452}
4 years, 8 months ago (2016-04-01 00:52:33 UTC) #9
Ken Russell (switch to Gerrit)
4 years, 8 months ago (2016-04-01 00:59:53 UTC) #10
Message was sent while issue was closed.
On 2016/04/01 00:52:33, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/0d4b3081c987155b6e5ae3d2f9058ddf3af7013f
> Cr-Commit-Position: refs/heads/master@{#384452}

This CL should have referred to http://crbug.com/599333 .

Powered by Google App Engine
This is Rietveld 408576698